[Feat] feat: add poolId -> poolKey mapping #91
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
lgtm, wait and see if we really want to merge it probably do the same thing for bin pool |
agree, if we are okay with this, I'll add this on bin pool as well within this PR |
ChefMist
commented
Jun 27, 2024
| @@ -0,0 +1 @@ | |||
| 162167 | |||
There was a problem hiding this comment.
originally was 71,099 so around 90k increase as well
ChefMist
changed the title
ChefMist
requested review from
ChefSnoopy,
ChefCupcake,
chef-omelette and
chefburger
chefburger
approved these changes
Jun 28, 2024
|
created #98 to track if this is needed after further developments |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds
poolIdToPoolKeymapping.Context
In order to retrieve the mapping currently, we need to rely on off-chain indexer. However if off-chain indexer has a problem, we cannot retrieve the mapping from
poolid -> poolKey.This PR adds the mapping on-chain. The result is around ~90k more gas for CLPool to store in a pool.initialize.
58,707 -> 149,801Assume ETH at $5000 and gas at 10 gwei. it will cost 0.0009 more eth = $4.5