Feat/audit part6 #165
Merged
Feat/audit part6 #165
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ChefMist
reviewed
Sep 9, 2024
| @@ -23,11 +25,12 @@ abstract contract ProtocolFees is IProtocolFees, Owner { | |||
| /// @inheritdoc IProtocolFees | |||
| IVault public immutable vault; | |||
|
|
|||
| uint256 private immutable controllerGasLimit; | |||
| // a percentage of the block.gaslimit denoted in basis points, used as the gas limit for fee controller calls | |||
| // 100 bps is 1%, at 30M gas, the limit is 300K | |||
There was a problem hiding this comment.
(just comment) this mean likely 300k on eth, and 1mil gas on bsc chain
ChefMist
reviewed
Sep 9, 2024
| uint256 balance = currency.balanceOfSelf(); | ||
| VaultReserve.setVaultReserve(currency, balance); | ||
| if (currency.isNative()) { | ||
| VaultReserve.setVaultReserve(CurrencyLibrary.NATIVE, 0); |
There was a problem hiding this comment.
i wonder if we can have a helper function so its clearer eg. VaultReserve.clearVaultReserve() or something
and within the helper function, we can document why its set currencyLibrary.Native and 0 amount
There was a problem hiding this comment.
if agreeable, we can create an issue to tackle in another PR (so it doesn't pollute this)
ChefMist
previously approved these changes
Sep 9, 2024
|
@ChefSnoopy Feel free to add any retrospective comments |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.