Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Add min max full range to url and remove min tick limit #10993

Open
wants to merge 4 commits into
base: develop
Choose a base branch
from

Conversation

memoyil
Copy link
Collaborator

@memoyil memoyil commented Nov 30, 2024


PR-Codex overview

This PR focuses on enhancing the handling of price input ranges in the AddLiquidityV3 module by allowing the range inputs to accept a boolean value (true) in addition to the existing types. This change simplifies certain conditions and updates related components accordingly.

Detailed summary

  • Updated typeLeftRangeInput and typeRightRangeInput to accept true as a valid typedValue.
  • Modified useInitialRange to handle true as a valid input for price ranges.
  • Removed setFullRange dispatch from useRangeHopCallbacks.
  • Integrated onSetFullRange into useV3MintActionHandlers.
  • Adjusted onBothRangePriceInput and other related functions to accommodate boolean values.
  • Updated useV3MintActionHandlers to handle true in typedValue and adjust query parameters accordingly.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

Copy link

vercel bot commented Nov 30, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
web ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 1, 2024 7:36pm
6 Skipped Deployments
Name Status Preview Comments Updated (UTC)
aptos-web ⬜️ Ignored (Inspect) Visit Preview Dec 1, 2024 7:36pm
blog ⬜️ Ignored (Inspect) Visit Preview Dec 1, 2024 7:36pm
bridge ⬜️ Ignored (Inspect) Visit Preview Dec 1, 2024 7:36pm
games ⬜️ Ignored (Inspect) Visit Preview Dec 1, 2024 7:36pm
gamification ⬜️ Ignored (Inspect) Visit Preview Dec 1, 2024 7:36pm
uikit ⬜️ Ignored (Inspect) Visit Preview Dec 1, 2024 7:36pm

Copy link

changeset-bot bot commented Nov 30, 2024

⚠️ No Changeset found

Latest commit: 20cb647

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@memoyil memoyil force-pushed the feature/fix_add_min_max_full_range_url_remove_min_tick_limit branch from 48d320b to 205ccff Compare November 30, 2024 17:34
@memoyil memoyil marked this pull request as ready for review November 30, 2024 17:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant