New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[v4] clear warning about `sync` #36

Open

ChefMist opened this issue Sep 9, 2024 · 0 comments

Collaborator

ChefMist commented Sep 9, 2024

after this is merged: pancakeswap/pancake-v4-core#165

if a user does this:

vault.sync(token1)
transfer token1 to vault
forget to call vault.settle(token1) but call vault.sync(token2)

then whatever token sent to vault might be lost if transaction didn't revert

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment