Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider using [0-9] pattern for TimePicker component #6852

Open
evansjohnson opened this issue Jun 18, 2024 · 0 comments
Open

Consider using [0-9] pattern for TimePicker component #6852

evansjohnson opened this issue Jun 18, 2024 · 0 comments

Comments

@evansjohnson
Copy link
Contributor

Splitting out from #3434 (comment)

The keyboard for a TimePicker component was updated to a full numeric keyboard in #6568 by adding a type="number" prop to the input element.

From a linked GOV.UK article in the original issue there was a suggestion to use type="text" inputmode="numeric" pattern="[0-9]*". While the accessibility concerns reported there for type="number" seem to no longer apply, the TimePicker component may still benefit from the [0-9]* pattern since other characters should not be relevant.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant