[BUG] fix #5038 update shedinja's gender to genderless on evolution #5039
+4
−0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What are the changes the user will see?
Upon evolving Nincada, users will always see Sheninja as genderless.
Why am I making these changes?
This is my first contribution to Pokerogue, I found an issue that looks fun to look into 😄
I believe enforcing providing correct gender would provide users more accurate experience.
fixes #5038
What are the changes from a developer perspective?
On a private method
handleSpecialEvolutions
specifically targetted for the nincada's evolution called on evolve method, I added the line to update the gender attribute to be genderless.Screenshots/Videos
Screenshot:
Video:
Screen.Recording.2024-12-24.at.8.51.45.PM.mov
How to test the changes?
I update
src/overrides.ts
to include these fields and start a new game, wait until I get a rare candy to trigger Nincada's evolution.Note:
It might be a good idea to update the fusionGender of Shedinja to be genderless. I can also include it in this PR as well, but I'll leave it up to the team to decide 👍🏼
Checklist
beta
as my base branchnpm run test
)npm run create-test
) or updated existing tests related to the PR's changes?