Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] fix #5038 update shedinja's gender to genderless on evolution #5039

Open
wants to merge 2 commits into
base: beta
Choose a base branch
from

Conversation

asukakuwahara
Copy link

@asukakuwahara asukakuwahara commented Dec 24, 2024

What are the changes the user will see?

Upon evolving Nincada, users will always see Sheninja as genderless.

Why am I making these changes?

This is my first contribution to Pokerogue, I found an issue that looks fun to look into 😄
I believe enforcing providing correct gender would provide users more accurate experience.
fixes #5038

What are the changes from a developer perspective?

On a private method handleSpecialEvolutions specifically targetted for the nincada's evolution called on evolve method, I added the line to update the gender attribute to be genderless.

Screenshots/Videos

Screenshot:
Screen Shot 2024-12-24 at 8 52 45 PM

Video:

Screen.Recording.2024-12-24.at.8.51.45.PM.mov

How to test the changes?

I update src/overrides.ts to include these fields and start a new game, wait until I get a rare candy to trigger Nincada's evolution.

STARTER_SPECIES_OVERRIDE: Species.NINCADA,
XP_MULTIPLIER_OVERRIDE: 999,
STARTING_LEVEL_OVERRIDE: 20,

Note:

It might be a good idea to update the fusionGender of Shedinja to be genderless. I can also include it in this PR as well, but I'll leave it up to the team to decide 👍🏼

Checklist

  • I'm using beta as my base branch
  • There is no overlap with another PR?
  • The PR is self-contained and cannot be split into smaller PRs?
  • Have I provided a clear explanation of the changes?
  • Have I tested the changes manually?
  • Are all unit tests still passing? (npm run test)
    • Have I created new automated tests (npm run create-test) or updated existing tests related to the PR's changes?
  • Have I provided screenshots/videos of the changes (if applicable)?
    • Have I made sure that any UI change works for both UI themes (default and legacy)?

@asukakuwahara asukakuwahara requested a review from a team as a code owner December 24, 2024 12:21
@Madmadness65 Madmadness65 added the P2 Bug Minor. Non crashing Incorrect move/ability/interaction label Dec 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P2 Bug Minor. Non crashing Incorrect move/ability/interaction
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] Shedinja is Gendered after Nincada Evolves
2 participants