Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

additionalProperties: true should not be allowed #55

Closed
mefellows opened this issue Jun 20, 2024 · 2 comments
Closed

additionalProperties: true should not be allowed #55

mefellows opened this issue Jun 20, 2024 · 2 comments
Labels
bug Something isn't working good first issue Good for newcomers smartbear-supported Issues with this label have been added to the Pactflow team's Jira backlog

Comments

@mefellows
Copy link
Contributor

The following comparison fails with additional properties set to false: https://github.com/gnanendra-bogireddy/pactflow-compatibility-check.

Change additionalProperties: true and the tests pass.

This should not be allowed. See also #38.

@mefellows mefellows added bug Something isn't working smartbear-supported Issues with this label have been added to the Pactflow team's Jira backlog good first issue Good for newcomers labels Jun 20, 2024
Copy link
Contributor

👋 Hi! The 'smartbear-supported' label has just been added to this issue, which will create an internal tracking ticket in PactFlow's Jira (PACT-2099). We will use this to prioritise and assign a team member to this task. All activity will be public on this ticket. For now, sit tight and we'll update this ticket once we have more information on the next steps.

See our documentation for more information.

@mefellows
Copy link
Contributor Author

Actually, this is not a bug.

Additional properties on the request body are not problematic and shouldn't cause this to fail, and is a violation of Postel's law. Standard semantics of additionalProperties are retained in this tool.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working good first issue Good for newcomers smartbear-supported Issues with this label have been added to the Pactflow team's Jira backlog
Projects
None yet
Development

No branches or pull requests

1 participant