Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

find_message_type_by_name not really search in all descriptors #11

Open
jojoxhsieh opened this issue Sep 27, 2022 · 2 comments
Open

find_message_type_by_name not really search in all descriptors #11

jojoxhsieh opened this issue Sep 27, 2022 · 2 comments
Labels
bug Something isn't working

Comments

@jojoxhsieh
Copy link

In method find_message_type_by_name, it try to search message by name in all descriptors, but it looks like just return error if it can't find message in the first descriptor, and won't continue.

For example, I have descriptors = [Some("google/protobuf/timestamp.proto"), Some("google/protobuf/duration.proto"), Some("feast/types/Value.proto"), Some("feast/types/Field.proto"), Some("feast/types/FeatureRow.proto"), Some("ServingService.proto")].
And set pact:proto to ServingService.proto.
When running consumer testing, I got error:
Failed to set the interaction: Failed to process protobuf: Did not find a message type 'Value' in the file descriptor 'Some("ServingService.proto")'
But actually Value is defined in Value.proto

@rholshausen rholshausen added the bug Something isn't working label Oct 4, 2022
@rholshausen
Copy link
Contributor

I can't replicate this, in my test the find_message_type_by_name function does look in all descriptors.

The problem must be somewhere else. Can you provide debug logs? Also, maybe try the latest version of the plugin. It may have been fixed with the changes from one of the other fixes.

@rkrishnan2012
Copy link
Contributor

I think this is the issue that was fixed in #36 and #30. I would suggest you try in the latest version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants