Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check for img in README if it's a theme or color scheme #2

Open
math2001 opened this issue Jan 5, 2017 · 2 comments
Open

Check for img in README if it's a theme or color scheme #2

math2001 opened this issue Jan 5, 2017 · 2 comments

Comments

@math2001
Copy link

math2001 commented Jan 5, 2017

Hi!

I've been looking at the code, and I saw that you were checking if there is readme. So maybe you could also check for an image if there is a .sublime-theme or .tmTheme in the package.

Thanks for package_reviewer anyway 👍

Matt

@FichteFoll
Copy link
Member

This is going to be difficult, because at this moment the checks are self-contained and I do readme checking in the repository tests (because github can detect mutiple readme locations) but would have to look for theme or color schemes file in the actual package (which I download later).

I'll have to think about how I would go about this, but thanks for the useful suggestions.

@Kristinita
Copy link

@math2001 , GitHub file README.MD provide limited features (for example, users don't can use JavaScript). I move description of my theme/scheme to HTML-file.

I don't think, that image in README.MD must be necessarily.

Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

No branches or pull requests

3 participants