Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: apply latest test suite data #35

Open
jkowalleck opened this issue Jan 3, 2022 · 1 comment · Fixed by #43
Open

feat: apply latest test suite data #35

jkowalleck opened this issue Jan 3, 2022 · 1 comment · Fixed by #43
Labels
QA Quality Assurance
Milestone

Comments

@jkowalleck
Copy link
Member

jkowalleck commented Jan 3, 2022

latest test suitedata https://github.com/package-url/purl-spec/blob/master/test-suite-data.json
the data is currently used in: https://github.com/package-url/packageurl-php/blob/main/tests/_examples/test-suite-data.json

pull latest test suite data and run tests against it.
if fixes are needed: create bug-reports/feature-requests for it
⚠️ fixes may be part of https://github.com/package-url/packageurl-php/milestone/2 but dont need to pass right away

@jkowalleck jkowalleck added this to the v1.4 milestone Jan 3, 2022
@jkowalleck jkowalleck added the QA Quality Assurance label Jan 3, 2022
jkowalleck added a commit that referenced this issue Jan 4, 2022
fixes #35

Signed-off-by: Jan Kowalleck <[email protected]>
@jkowalleck jkowalleck modified the milestones: v1.4, v1.5 Jan 4, 2022
@jkowalleck jkowalleck changed the title feat: comply latest test suite data feat: apply latest test suite data Jan 4, 2022
jkowalleck added a commit that referenced this issue Jan 4, 2022
fixes #35

Signed-off-by: Jan Kowalleck <[email protected]>
jkowalleck added a commit that referenced this issue Jan 4, 2022
fixes #35

Signed-off-by: Jan Kowalleck <[email protected]>
@jkowalleck
Copy link
Member Author

latest test results:

There were 6 failures:

1) PackageUrl\Tests\PackageUrlParserTest::testParseAndNormalize with data set "invalid conan purl only namespace" (array('invalid conan purl only namespace', 'pkg:conan/bincrafters/[email protected]', 'pkg:conan/bincrafters/[email protected]', 'conan', 'bincrafters', 'cctz', '2.3', null, null, true))
Failed asserting that two arrays are not identical.

/home/flow/Documents/Coding/php/packageurl-php/tests/PackageUrlParserTest.php:156

2) PackageUrl\Tests\PackageUrlParserTest::testParseAndNormalize with data set "invalid cran purl without name" (array('invalid cran purl without name', 'pkg:cran/@0.9.1', 'pkg:cran/@0.9.1', 'cran', null, null, '0.9.1', null, null, true))
Failed asserting that two arrays are not identical.

/home/flow/Documents/Coding/php/packageurl-php/tests/PackageUrlParserTest.php:156

3) PackageUrl\Tests\PackageUrlParserTest::testParseAndNormalize with data set "invalid cran purl without version" (array('invalid cran purl without version', 'pkg:cran/A3', 'pkg:cran/A3', 'cran', null, 'A3', null, null, null, true))
Failed asserting that two arrays are not identical.

/home/flow/Documents/Coding/php/packageurl-php/tests/PackageUrlParserTest.php:156

4) PackageUrl\Tests\PackageUrlParserTest::testParseAndNormalize with data set "invalid swift purl without namespace" (array('invalid swift purl without namespace', 'pkg:swift/[email protected]', 'pkg:swift/[email protected]', 'swift', null, 'Alamofire', '5.4.3', null, null, true))
Failed asserting that two arrays are not identical.

/home/flow/Documents/Coding/php/packageurl-php/tests/PackageUrlParserTest.php:156

5) PackageUrl\Tests\PackageUrlParserTest::testParseAndNormalize with data set "name and version are always required" (array('name and version are always required', 'pkg:hackage', 'pkg:hackage', 'hackage', null, null, null, null, null, true))
Failed asserting that two arrays are not identical.

/home/flow/Documents/Coding/php/packageurl-php/tests/PackageUrlParserTest.php:156

6) PackageUrl\Tests\PackageUrlParserTest::testParseAndNormalize with data set "invalid conan purl only channel qualifier" (array('invalid conan purl only chann...lifier', 'pkg:conan/[email protected]?channel=stable', 'pkg:conan/[email protected]?channel=stable', 'conan', null, 'cctz', '2.3', array('stable'), null, true))
Failed asserting that two arrays are not identical.

/home/flow/Documents/Coding/php/packageurl-php/tests/PackageUrlParserTest.php:156

FAILURES!
Tests: 208, Assertions: 228, Failures: 6.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
QA Quality Assurance
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant