From dc5ef1e4918b1bc471991ac44d8e4c0bb5cc17fc Mon Sep 17 00:00:00 2001 From: Yossi Shwartz Date: Mon, 11 Nov 2019 10:54:17 +0200 Subject: [PATCH 1/3] adding condition for ellipsis --- src/Truncate.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/Truncate.js b/src/Truncate.js index a060ebff..a4d88f38 100644 --- a/src/Truncate.js +++ b/src/Truncate.js @@ -80,7 +80,7 @@ export default class Truncate extends Component { timeout } = this; - ellipsis.parentNode.removeChild(ellipsis); + if (ellipsis) ellipsis.parentNode.removeChild(ellipsis); window.removeEventListener('resize', onResize); From b423b36304a1c800b30f1fc0f7750ba3316448ab Mon Sep 17 00:00:00 2001 From: Yossi Shwartz Date: Mon, 11 Nov 2019 11:10:20 +0200 Subject: [PATCH 2/3] Update Truncate.js --- src/Truncate.js | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/src/Truncate.js b/src/Truncate.js index a4d88f38..943ea69b 100644 --- a/src/Truncate.js +++ b/src/Truncate.js @@ -80,7 +80,9 @@ export default class Truncate extends Component { timeout } = this; - if (ellipsis) ellipsis.parentNode.removeChild(ellipsis); + if (ellipsis) { + ellipsis.parentNode.removeChild(ellipsis); + } window.removeEventListener('resize', onResize); From d1c88cfca682ec0e89f397713a5b63ded36f29b1 Mon Sep 17 00:00:00 2001 From: eluxen Date: Tue, 26 Nov 2019 16:35:15 +0200 Subject: [PATCH 3/3] optional listen to window resize event --- src/Truncate.js | 5 ----- 1 file changed, 5 deletions(-) diff --git a/src/Truncate.js b/src/Truncate.js index 943ea69b..eb3e2d39 100644 --- a/src/Truncate.js +++ b/src/Truncate.js @@ -55,8 +55,6 @@ export default class Truncate extends Component { text.parentNode.removeChild(text); } }); - - window.addEventListener('resize', onResize); } componentDidUpdate(prevProps) { @@ -83,9 +81,6 @@ export default class Truncate extends Component { if (ellipsis) { ellipsis.parentNode.removeChild(ellipsis); } - - window.removeEventListener('resize', onResize); - window.cancelAnimationFrame(timeout); }