Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Does not build for node 22 #34

Open
ignoramous opened this issue Jun 24, 2024 · 1 comment
Open

Does not build for node 22 #34

ignoramous opened this issue Jun 24, 2024 · 1 comment

Comments

@ignoramous
Copy link

This is from my local box running Ubuntu 22.04:

npm error code 1
npm error path /home/bravehub/serverless-dns/node_modules/mmap-utils
npm error command failed
npm error command sh -c npm run build-addon
npm error > [email protected] build-addon
npm error > node-gyp configure && node-gyp rebuild
npm error
npm error
npm error
npm error make: Entering directory '/home/bravehub/serverless-dns/node_modules/mmap-utils/build'
npm error   CXX(target) Release/obj.target/mmap-utils/src/mmap-utils.o
npm error make: Leaving directory '/home/bravehub/serverless-dns/node_modules/mmap-utils/build'
npm error gyp info it worked if it ends with ok
npm error gyp info using [email protected]
npm error gyp info using [email protected] | linux | x64
npm error gyp info find Python using Python version 3.8.10 found at "/usr/bin/python3"
npm error gyp info spawn /usr/bin/python3
npm error gyp info spawn args [
npm error gyp info spawn args '/home/.nvm/versions/node/v22.3.0/lib/node_modules/npm/node_modules/node-gyp/gyp/gyp_main.py',
npm error gyp info spawn args 'binding.gyp',
npm error gyp info spawn args '-f',
npm error gyp info spawn args 'make',
npm error gyp info spawn args '-I',
npm error gyp info spawn args '/home/bravehub/serverless-dns/node_modules/mmap-utils/build/config.gypi',
npm error gyp info spawn args '-I',
npm error gyp info spawn args '/home/.nvm/versions/node/v22.3.0/lib/node_modules/npm/node_modules/node-gyp/addon.gypi',
npm error gyp info spawn args '-I',
npm error gyp info spawn args '/home/.cache/node-gyp/22.3.0/include/node/common.gypi',
npm error gyp info spawn args '-Dlibrary=shared_library',
npm error gyp info spawn args '-Dvisibility=default',
npm error gyp info spawn args '-Dnode_root_dir=/home/.cache/node-gyp/22.3.0',
npm error gyp info spawn args '-Dnode_gyp_dir=/home/.nvm/versions/node/v22.3.0/lib/node_modules/npm/node_modules/node-gyp',
npm error gyp info spawn args '-Dnode_lib_file=/home/.cache/node-gyp/22.3.0/<(target_arch)/node.lib',
npm error gyp info spawn args '-Dmodule_root_dir=/home/bravehub/serverless-dns/node_modules/mmap-utils',
npm error gyp info spawn args '-Dnode_engine=v8',
npm error gyp info spawn args '--depth=.',
npm error gyp info spawn args '--no-parallel',
npm error gyp info spawn args '--generator-output',
npm error gyp info spawn args 'build',
npm error gyp info spawn args '-Goutput_dir=.'
npm error gyp info spawn args ]
npm error gyp info ok 
npm error gyp info it worked if it ends with ok
npm error gyp info using [email protected]
npm error gyp info using [email protected] | linux | x64
npm error gyp info find Python using Python version 3.8.10 found at "/usr/bin/python3"
npm error gyp info spawn /usr/bin/python3
npm error gyp info spawn args [
npm error gyp info spawn args '/home/.nvm/versions/node/v22.3.0/lib/node_modules/npm/node_modules/node-gyp/gyp/gyp_main.py',
npm error gyp info spawn args 'binding.gyp',
npm error gyp info spawn args '-f',
npm error gyp info spawn args 'make',
npm error gyp info spawn args '-I',
npm error gyp info spawn args '/home/bravehub/serverless-dns/node_modules/mmap-utils/build/config.gypi',
npm error gyp info spawn args '-I',
npm error gyp info spawn args '/home/.nvm/versions/node/v22.3.0/lib/node_modules/npm/node_modules/node-gyp/addon.gypi',
npm error gyp info spawn args '-I',
npm error gyp info spawn args '/home/.cache/node-gyp/22.3.0/include/node/common.gypi',
npm error gyp info spawn args '-Dlibrary=shared_library',
npm error gyp info spawn args '-Dvisibility=default',
npm error gyp info spawn args '-Dnode_root_dir=/home/.cache/node-gyp/22.3.0',
npm error gyp info spawn args '-Dnode_gyp_dir=/home/.nvm/versions/node/v22.3.0/lib/node_modules/npm/node_modules/node-gyp',
npm error gyp info spawn args '-Dnode_lib_file=/home/.cache/node-gyp/22.3.0/<(target_arch)/node.lib',
npm error gyp info spawn args '-Dmodule_root_dir=/home/bravehub/serverless-dns/node_modules/mmap-utils',
npm error gyp info spawn args '-Dnode_engine=v8',
npm error gyp info spawn args '--depth=.',
npm error gyp info spawn args '--no-parallel',
npm error gyp info spawn args '--generator-output',
npm error gyp info spawn args 'build',
npm error gyp info spawn args '-Goutput_dir=.'
npm error gyp info spawn args ]
npm error gyp info spawn make
npm error gyp info spawn args [ 'BUILDTYPE=Release', '-C', 'build' ]
npm error In file included from ../src/mmap-utils.cc:10:
npm error ../../nan/nan.h: In function ‘void Nan::SetAccessor(v8::Local<v8::ObjectTemplate>, v8::Local<v8::String>, Nan::GetterCallback, Nan::SetterCallback, v8::Local<v8::Value>, v8::AccessControl, v8::PropertyAttribute, Nan::imp::Sig)’:
npm error ../../nan/nan.h:2556:3: error: no matching function for call to ‘v8::ObjectTemplate::SetAccessor(v8::Local<v8::String>&, void (*&)(v8::Local<v8::Name>, const v8::PropertyCallbackInfo<v8::Value>&), void (*&)(v8::Local<v8::Name>, v8::Local<v8::Value>, const v8::PropertyCallbackInfo<void>&), v8::Local<v8::Object>&, v8::AccessControl&, v8::PropertyAttribute&)’
npm error  2556 |   );
npm error       |   ^
npm error In file included from /home/.cache/node-gyp/22.3.0/include/node/v8-function.h:15,
npm error                  from /home/.cache/node-gyp/22.3.0/include/node/v8.h:33,
npm error                  from /home/.cache/node-gyp/22.3.0/include/node/node.h:73,
npm error                  from ../../nan/nan.h:60,
npm error                  from ../src/mmap-utils.cc:10:
npm error /home/.cache/node-gyp/22.3.0/include/node/v8-template.h:1049:8: note: candidate: ‘void v8::ObjectTemplate::SetAccessor(v8::Local<v8::String>, v8::AccessorGetterCallback, v8::AccessorSetterCallback, v8::Local<v8::Value>, v8::PropertyAttribute, v8::SideEffectType, v8::SideEffectType)’
npm error  1049 |   void SetAccessor(
npm error       |        ^~~~~~~~~~~
npm error /home/.cache/node-gyp/22.3.0/include/node/v8-template.h:1052:61: note:   no known conversion for argument 5 from ‘v8::AccessControl’ to ‘v8::PropertyAttribute’
npm error  1052 |       Local<Value> data = Local<Value>(), PropertyAttribute attribute = None,
npm error       |                                           ~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~
npm error /home/.cache/node-gyp/22.3.0/include/node/v8-template.h:1055:8: note: candidate: ‘void v8::ObjectTemplate::SetAccessor(v8::Local<v8::Name>, v8::AccessorNameGetterCallback, v8::AccessorNameSetterCallback, v8::Local<v8::Value>, v8::PropertyAttribute, v8::SideEffectType, v8::SideEffectType)’
npm error  1055 |   void SetAccessor(
npm error       |        ^~~~~~~~~~~
npm error /home/.cache/node-gyp/22.3.0/include/node/v8-template.h:1058:61: note:   no known conversion for argument 5 from ‘v8::AccessControl’ to ‘v8::PropertyAttribute’
npm error  1058 |       Local<Value> data = Local<Value>(), PropertyAttribute attribute = None,
npm error       |                                           ~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~
npm error In file included from ../src/mmap-utils.cc:10:
npm error ../../nan/nan.h: In function ‘void Nan::SetAccessor(v8::Local<v8::ObjectTemplate>, v8::Local<v8::String>, Nan::GetterCallback, Nan::SetterCallback, v8::Local<v8::Value>, v8::AccessControl, v8::PropertyAttribute)’:
npm error ../../nan/nan.h:2599:3: error: no matching function for call to ‘v8::ObjectTemplate::SetAccessor(v8::Local<v8::String>&, void (*&)(v8::Local<v8::Name>, const v8::PropertyCallbackInfo<v8::Value>&), void (*&)(v8::Local<v8::Name>, v8::Local<v8::Value>, const v8::PropertyCallbackInfo<void>&), v8::Local<v8::Object>&, v8::AccessControl&, v8::PropertyAttribute&)’
npm error  2599 |   );
npm error       |   ^
npm error In file included from /home/.cache/node-gyp/22.3.0/include/node/v8-function.h:15,
npm error                  from /home/.cache/node-gyp/22.3.0/include/node/v8.h:33,
npm error                  from /home/.cache/node-gyp/22.3.0/include/node/node.h:73,
npm error                  from ../../nan/nan.h:60,
npm error                  from ../src/mmap-utils.cc:10:
npm error /home/.cache/node-gyp/22.3.0/include/node/v8-template.h:1049:8: note: candidate: ‘void v8::ObjectTemplate::SetAccessor(v8::Local<v8::String>, v8::AccessorGetterCallback, v8::AccessorSetterCallback, v8::Local<v8::Value>, v8::PropertyAttribute, v8::SideEffectType, v8::SideEffectType)’
npm error  1049 |   void SetAccessor(
npm error       |        ^~~~~~~~~~~
npm error /home/.cache/node-gyp/22.3.0/include/node/v8-template.h:1052:61: note:   no known conversion for argument 5 from ‘v8::AccessControl’ to ‘v8::PropertyAttribute’
npm error  1052 |       Local<Value> data = Local<Value>(), PropertyAttribute attribute = None,
npm error       |                                           ~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~
npm error /home/.cache/node-gyp/22.3.0/include/node/v8-template.h:1055:8: note: candidate: ‘void v8::ObjectTemplate::SetAccessor(v8::Local<v8::Name>, v8::AccessorNameGetterCallback, v8::AccessorNameSetterCallback, v8::Local<v8::Value>, v8::PropertyAttribute, v8::SideEffectType, v8::SideEffectType)’
npm error  1055 |   void SetAccessor(
npm error       |        ^~~~~~~~~~~
npm error /home/.cache/node-gyp/22.3.0/include/node/v8-template.h:1058:61: note:   no known conversion for argument 5 from ‘v8::AccessControl’ to ‘v8::PropertyAttribute’
npm error  1058 |       Local<Value> data = Local<Value>(), PropertyAttribute attribute = None,
npm error       |                                           ~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~
npm error In file included from /home/.cache/node-gyp/22.3.0/include/node/v8-array-buffer.h:12,
npm error                  from /home/.cache/node-gyp/22.3.0/include/node/v8.h:24,
npm error                  from /home/.cache/node-gyp/22.3.0/include/node/node.h:73,
npm error                  from ../../nan/nan.h:60,
npm error                  from ../src/mmap-utils.cc:10:
npm error /home/.cache/node-gyp/22.3.0/include/node/v8-local-handle.h: In instantiation of ‘v8::Local<T>::Local(v8::Local<S>) [with S = v8::Data; T = v8::Value]’:
npm error ../../nan/nan_callbacks_12_inl.h:175:53:   required from here
npm error /home/.cache/node-gyp/22.3.0/include/node/v8-local-handle.h:269:42: error: static assertion failed: type check
npm error   269 |     static_assert(std::is_base_of<T, S>::value, "type check");
npm error       |                                          ^~~~~
npm error make: *** [mmap-utils.target.mk:110: Release/obj.target/mmap-utils/src/mmap-utils.o] Error 1
npm error gyp ERR! build error 
npm error gyp ERR! stack Error: `make` failed with exit code: 2
npm error gyp ERR! stack at ChildProcess.<anonymous> (/home/.nvm/versions/node/v22.3.0/lib/node_modules/npm/node_modules/node-gyp/lib/build.js:209:23)
npm error gyp ERR! System Linux 5.4.0-165-generic
npm error gyp ERR! command "/home/.nvm/versions/node/v22.3.0/bin/node" "/home/.nvm/versions/node/v22.3.0/lib/node_modules/npm/node_modules/node-gyp/bin/node-gyp.js" "rebuild"
npm error gyp ERR! cwd /home/bravehub/serverless-dns/node_modules/mmap-utils
npm error gyp ERR! node -v v22.3.0
npm error gyp ERR! node-gyp -v v10.1.0
npm error gyp ERR! not ok
@ignoramous
Copy link
Author

Fixed at: ARyaskov@3ae0e53

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@ignoramous