Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consider enabling callbacks provided to `WithRemoteData #4

Open
oyvindberg opened this issue Oct 6, 2022 · 1 comment
Open

Consider enabling callbacks provided to `WithRemoteData #4

oyvindberg opened this issue Oct 6, 2022 · 1 comment

Comments

@oyvindberg
Copy link
Owner 

    Would  it make sense to have `onPending` and `onError` callback props as well?

Originally posted by @jestho in #2 (comment)
@oyvindberg
Copy link
Owner Author

It would make a lot of sense, but I'll defer the decision.

The () => Promise<T> function passed to useRemoteData is currently the place to put those callbacks, and there is some value in having few ways of expressing the same think.

Should at least go in documentation though.

@oyvindberg oyvindberg mentioned this issue Oct 6, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@oyvindberg