Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sbt plugin #52

Open
oyvindberg opened this issue Oct 17, 2023 · 4 comments
Open

sbt plugin #52

oyvindberg opened this issue Oct 17, 2023 · 4 comments
Labels
help wanted Extra attention is needed

Comments

@oyvindberg
Copy link
Owner

No description provided.

@oyvindberg oyvindberg added the help wanted Extra attention is needed label Oct 17, 2023
@kolemannix
Copy link

kolemannix commented Jul 22, 2024

For what it's worth, I had an sbt task working but apparently it depended on the Scala 2.12 copy of typo (I added typo as a meta-build dependency in project/build.sbt) but now that it's not published for 2.12 this approach does not work. I'm sure a plugin could get around this but it seems that the SBT meta-project itself runs in Scala 2.12 still.

@oyvindberg
Copy link
Owner Author

Hey that's great!

I added support for 2.12 in typo originally precisely to support this case. An sbt plugin was a logical thing to do.
I haven't gotten around to it myself, and I removed support for 2.12 in #92 because it was a drain on my resources to compile everything for 2.12 - there is a lot of test code to compile, and a full test run must compile (number of libraries, 3) * scala versions (was 3, now 2).

However, there is an easy way out. Let's say that typo itself is published for 2.12, but the resulting generated code only works for 2.13+. This is likely a 5 minute job to copy some compatibility code back in and publish 👍

oyvindberg added a commit that referenced this issue Jul 25, 2024
This reverts part of #92, but only for the code generation code. the generated code will not work for 2.12
oyvindberg added a commit that referenced this issue Jul 25, 2024
This reverts part of #92, but only for the code generation code. the generated code will not work for 2.12
@oyvindberg
Copy link
Owner Author

I'm adding the port to 2.12 again in #127 .

oyvindberg added a commit that referenced this issue Jul 25, 2024
This reverts part of #92, but only for the code generation code. the generated code will not work for 2.12
oyvindberg added a commit that referenced this issue Jul 25, 2024
This reverts part of #92, but only for the code generation code. the generated code will not work for 2.12
oyvindberg added a commit that referenced this issue Jul 25, 2024
This reverts part of #92, but only for the code generation code. the generated code will not work for 2.12
@kolemannix
Copy link

Hey, great! Will polish my task up and at least post a gist; obviously it needs to be converted from a task to a plugin and some thought given to its sbt API

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants