Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(napi/transform): isolatedDeclarations returns detailed error messages #3934

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Dunqing
Copy link
Member

@Dunqing Dunqing commented Jun 27, 2024

close: #3913

Copy link

graphite-app bot commented Jun 27, 2024

Your org has enabled the Graphite merge queue for merging into main

Add the label “merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

Copy link
Member Author

Dunqing commented Jun 27, 2024

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @Dunqing and the rest of your teammates on Graphite Graphite

Copy link

codspeed-hq bot commented Jun 27, 2024

CodSpeed Performance Report

Merging #3934 will not alter performance

Comparing 06-27-feat_napi_transform_isolateddeclarations_returns_detailed_error_messages (b5f8588) with main (3ae2628)

Summary

✅ 28 untouched benchmarks

@Dunqing Dunqing marked this pull request as draft June 27, 2024 10:17
@Dunqing Dunqing marked this pull request as ready for review June 28, 2024 06:33
@Dunqing Dunqing marked this pull request as draft June 28, 2024 06:33
@Boshen Boshen self-assigned this Jun 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

isolatedDeclaration errors don't include line numbers
2 participants