Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Poor performance in fullscreen mode #29

Open
andrei-picus-hs opened this issue Aug 11, 2015 · 1 comment
Open

Poor performance in fullscreen mode #29

andrei-picus-hs opened this issue Aug 11, 2015 · 1 comment

Comments

@andrei-picus-hs
Copy link

Need

Performance.

Solution

Disable the fixture editor in fullscreen mode.

image

@ovidiuch
Copy link
Owner

Without much thought, the fix should be easy: Adding another condition here to return if this.props.editor is false.

An unexpected implication might occur in this scenario:

  1. Open a component with the editor closed
  2. Generate state changes (component playground will not capture the state changes because the editor is closed)
  3. Open the editor (component playground will not update the component state because the editor will be focused)
  4. Click outside the editor and voilà, you'll get the actual component state in the editor.

Not sure if this is good or bad.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants