Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add mypy to the webapp #1560

Open
DavidKorczynski opened this issue Jun 11, 2024 · 2 comments · Fixed by #1563
Open

Add mypy to the webapp #1560

DavidKorczynski opened this issue Jun 11, 2024 · 2 comments · Fixed by #1563
Assignees

Comments

@DavidKorczynski
Copy link
Contributor

We recently had a regression that caused the webapp to fail after a sequence of API calls were made: #1559

I think we could have caught this using strict type checking since

all_functions.append(data_storage.get_constructors())
would have been caught by type analysis, as the line appends an element of type list, which is not the type of element the list holds.

@DavidKorczynski
Copy link
Contributor Author

@arthurscchan

@arthurscchan
Copy link
Contributor

The CI has discovered serveral existing problems and bugs in the web apps and they have been fixed before introducing this new CI. The fixes for these problems and bugs are merged in PRs #1564 #1565 #1566 #1567 #1568 #1569 #1570 #1577.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants