Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

log-scaled freqz-plots messed up #8

Open
oscargus opened this issue Feb 26, 2023 · 1 comment
Open

log-scaled freqz-plots messed up #8

oscargus opened this issue Feb 26, 2023 · 1 comment
Labels
bug Something isn't working enhancement New feature or request
Milestone

Comments

@oscargus
Copy link
Owner

As seen in https://github.com/oscargus/mplsignal/blob/main/mplsignal/tests/baseline_images/test_freq_plots/freqz_freq_units_log.png
the locators are not really working. One may consider if all should be available, one can maybe assume that one wants to use sample frequency if log-scale is used, not normalized frequency etc?

Also, the minor ticks should probably be enabled.

@oscargus oscargus added bug Something isn't working enhancement New feature or request labels Feb 27, 2023
@oscargus
Copy link
Owner Author

oscargus commented Mar 1, 2023

The bug-aspect of it is sort of fixed in #17, but it still looks quite bad as the formatter cannot handle it properly.

@oscargus oscargus added this to the later milestone Mar 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant