Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Possible annoying multiply posts when browser disconnected in process and server answer lost #663

Open
tgely opened this issue Jun 18, 2020 · 0 comments

Comments

@tgely
Copy link
Contributor

tgely commented Jun 18, 2020

If customer's browser disconnect between checkout process then possible to do more orders with refresh browser page and post again values.
This could be issue on more processes where post forms used because $sessiontoken never reset before redirections.

$sessiontoken never be examined (and if not set before) in checkout_process.php so possible to run more and more.

echo HTML::form('checkout_confirmation', $form_action_url, 'post');

unset($_SESSION['sendto']);
unset($_SESSION['billto']);
unset($_SESSION['shipping']);
unset($_SESSION['payment']);
unset($_SESSION['comments']);
OSCOM::redirect('checkout_success.php');

You could say that admin be able to delete multiply orders but some system stock sensitive so this issue prevent product offers until admin do an action.

Advice to reset $sessiontoken after process and before redirections and use $sessiontoken more widely.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant