Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feature Request]: Adding Breadcrumb Component #384

Closed
wants to merge 28 commits into from
Closed

[Feature Request]: Adding Breadcrumb Component #384

wants to merge 28 commits into from

Conversation

mouadTaoussi
Copy link
Contributor

@mouadTaoussi mouadTaoussi commented Jul 12, 2022 •
edited
Loading

Fixes #382

Proposed Changes

  • Adding component to oruga and oruga-next
  • Turn it to Draft as long as the docs is not updated, and the feature is not yet ready

@mouadTaoussi mouadTaoussi marked this pull request as draft July 12, 2022 11:10
@jtommy
Copy link
Member

jtommy commented Sep 28, 2022

@mouadTaoussi the PR is not correct. You haven't to put classes directly on html element and you can improve the scss in order to limit subclasses

@mouadTaoussi
Copy link
Contributor Author

@mouadTaoussi the PR is not correct. You haven't to put classes directly on html element and you can improve the scss in order to limit subclasses

I hard coded those classes temporary. Before passing to the logic part

@netlify
Copy link

netlify bot commented Oct 9, 2022 •
edited
Loading

❌ Deploy Preview for oruga-documentation-preview failed.

Name Link
🔨 Latest commit 4deae6f
🔍 Latest deploy log https://app.netlify.com/sites/oruga-documentation-preview/deploys/63582cbdd7a1af0008717d71

@mouadTaoussi mouadTaoussi reopened this Oct 24, 2022
@codecov
Copy link

codecov bot commented Oct 25, 2022 •
edited
Loading

Codecov Report

Base: 66.45% // Head: 66.58% // Increases project coverage by +0.12% 🎉

Coverage data is based on head (4deae6f) compared to base (2ab4729).
Patch coverage: 91.30% of modified lines in pull request are covered.

Additional details and impacted files 
@@             Coverage Diff             @@
##           develop     #384      +/-   ##
===========================================
+ Coverage    66.45%   66.58%   +0.12%     
===========================================
  Files           64       66       +2     
  Lines         4490     4513      +23     
  Branches      1179     1181       +2     
===========================================
+ Hits          2984     3005      +21     
- Misses        1405     1407       +2     
  Partials       101      101
Impacted Files Coverage Δ
...oruga/src/components/breadcrumb/BreadcrumbItem.vue 90.00% <90.00%> (ø)
...ges/oruga/src/components/breadcrumb/Breadcrumb.vue 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@mouadTaoussi mouadTaoussi marked this pull request as ready for review October 25, 2022 19:49
@jtommy jtommy closed this Dec 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Feature Request]: Add Breadcrumb Component
2 participants
@mouadTaoussi @jtommy