Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MacOS 15.1: Connection drops mid-command without throwing #87

Open
Marcocanc opened this issue Nov 18, 2024 · 3 comments
Open

MacOS 15.1: Connection drops mid-command without throwing #87

Marcocanc opened this issue Nov 18, 2024 · 3 comments
Assignees

Comments

@Marcocanc
Copy link
Contributor

Describe the bug
While running Cilicon on macOS 15.1 we have noticed that the command stream eventually fails without throwing or completing, causing Cilicon to get stuck waiting for a response.
We have hacked together a version of Cilicon that uses Process to run ssh/sshpass and we're not seeing this issue there, which indicates a problem on the client side.
I'm not sure whether this is an issue with Citadel or swift-nio.

Reproducer Sample
Cilicon 2.2.2 on macOS 15.1 with github provisioner (it may take quite a while for this issue to occur)

Expected behavior
Ideally the connection should not drop, but when it does the executeCommand function should throw.

Client (please complete the following information):

  • OS: macOS 15.1
  • Client: Citadel
  • Version of Citadel, if applicable: 0.7.2, 0.9.1

Server (please complete the following information):

  • OS: macOS 14.X, macOS 15.X
  • Server: opensshd
  • Version of Citadel, if applicable: --
@Joannis
Copy link
Member

Joannis commented Nov 19, 2024

@Marcocanc can you help me reproduce this? I couldn't find you on any Discord or Slack servers I'm a member of, but I'd love to get in touch about this.

@Marcocanc
Copy link
Contributor Author

I just spun up a Discord for Cilicon (will add it to the readme at some point). We can chat there! https://discord.gg/g2yyEMMx

@temap
Copy link

temap commented Nov 20, 2024

@Marcocanc I'm not sure if this is related to the library, but we're seeing crashes on Sequoia when Cilicon runs under a launchd agent, and the privacy prompt for local network access isn't approved. Since local network access isn't part of TCC, we have to log in to each machine and manually approve and then the crashes stop.

The issue is described here:
https://mjtsai.com/blog/2024/10/02/local-network-privacy-on-sequoia

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants