test_node_names is with a silent bug

[caioaamaral]

Here we are filtering a launch entity of type rclpy.node.Node, but I think it should be launch_ros.actions.Node instead

xacro_live/test/test_xacro_live_view_launch.py

Line 71 in f63adbd

lambda entity: isinstance(entity, rclpy.node.Node),

Some lines further we try to use launch_ros.actions.Node methods with a supposed rclpy.node.Node object:

xacro_live/test/test_xacro_live_view_launch.py

Line 90 in f63adbd

self.assertTrue(node.is_node_name_fully_specified())

So far we had no error here probably because nodes is an empty list since there is no launch entity of type rclpy.node.Node, and then no assertion is made:

nodes = set(
            filter(
                lambda entity: isinstance(entity, rclpy.node.Node),
                spawn_launch.get_sub_entities()[0].entities
            )
        )
.....
for node in nodes:
            proc_info.assertWaitForStartup(node, timeout=5)
            self.assertTrue(node.is_node_name_fully_specified())
            self.assertRegex(node.node_name, combined_regex)

Then we must also add an extra assertion to make sure nodes is not empty (or just make sure it is the same size as expected_nodes)