Suggest change for file outside of the changed files in PR #59057
Replies: 3 comments 2 replies
-
I have the same problem! |
Beta Was this translation helpful? Give feedback.
-
You can make a comment with ```suggestion as long as it starts and ends within 3 lines of a diff hunk (but it can't end on a deleted line). In the GitHub Advanced Security demo they have a ````suggestion` with "Outside changed files" targeting line 16 of package.json. I'd like to know how this is done. |
Beta Was this translation helpful? Give feedback.
-
🕒 Discussion Activity Reminder 🕒 This Discussion has been labeled as dormant by an automated system for having no activity in the last 60 days. Please consider one the following actions: 1️⃣ Close as Out of Date: If the topic is no longer relevant, close the Discussion as 2️⃣ Provide More Information: Share additional details or context — or let the community know if you've found a solution on your own. 3️⃣ Mark a Reply as Answer: If your question has been answered by a reply, mark the most helpful reply as the solution. Note: This dormant notification will only apply to Discussions with the Thank you for helping bring this Discussion to a resolution! 💬 |
Beta Was this translation helpful? Give feedback.
-
Select Topic Area
Question
Body
For our use case, we want to create a review, suggesting changes to files that are not included in the subset of the files changed in the PR but are affected by those changes. Currently, the
path
needs to point to one of the files in the PR set of changes.When sending a
path
that is outside, the response from the API is:{'message': 'Unprocessable Entity', 'errors': ["Pull request review thread path is invalid and Pull request review thread diff hunk can't be blank"]...}
Should we use a different functionality to achieve what we want?
Beta Was this translation helpful? Give feedback.
All reactions