getting style / linting errors for publish.yml and tests.yml workflow files using shellcheck 😕

[ipatch]

Output of brew config

na

Output of brew doctor

na

Description of issue

attempting to update a formula for the homebrew-freecad tap, i am now getting the below errors during the test-bot run using the github provided CI

==> Fetching shellcheck
  ==> Downloading https://ghcr.io/v2/homebrew/core/shellcheck/blobs/sha256:6d0867f144686a5caa025cb15ecac49286654b78e7b89979a54eedc9a0cc9b6b
  ==> Pouring shellcheck--0.10.0.x86_64_linux.bottle.tar.gz
  /home/linuxbrew/.linuxbrew/Cellar/shellcheck/0.10.0: 8 files, [33](https://github.com/FreeCAD/homebrew-freecad/actions/runs/9505775511/job/26201438494?pr=526#step:14:34)MB
  ../../../../linuxbrew/.linuxbrew/Homebrew/Library/Taps/freecad/homebrew-freecad/.github/workflows/publish.yml:29:9: shellcheck reported issue in this script: SC2086:info:1:28: Double quote to prevent globbing and word splitting [shellcheck]
     |
  29 |         run: brew pr-pull --debug --tap=$GITHUB_REPOSITORY $PULL_REQUEST
     |         ^~~~
  ../../../../linuxbrew/.linuxbrew/Homebrew/Library/Taps/freecad/homebrew-freecad/.github/workflows/publish.yml:29:9: shellcheck reported issue in this script: SC2086:info:1:47: Double quote to prevent globbing and word splitting [shellcheck]
     |
  29 |         run: brew pr-pull --debug --tap=$GITHUB_REPOSITORY $PULL_REQUEST
     |         ^~~~
  ../../../../linuxbrew/.linuxbrew/Homebrew/Library/Taps/freecad/homebrew-freecad/.github/workflows/publish.yml:[41](https://github.com/FreeCAD/homebrew-freecad/actions/runs/9505775511/job/26201438494?pr=526#step:14:42):9: shellcheck reported issue in this script: SC2086:info:1:26: Double quote to prevent globbing and word splitting [shellcheck]
     |
  41 |         run: git push --delete origin $BRANCH
     |         ^~~~
  ../../../../linuxbrew/.linuxbrew/Homebrew/Library/Taps/freecad/homebrew-freecad/.github/workflows/tests.yml:54:9: shellcheck reported issue in this script: SC2086:info:1:[45](https://github.com/FreeCAD/homebrew-freecad/actions/runs/9505775511/job/26201438494?pr=526#step:14:46): Double quote to prevent globbing and word splitting [shellcheck]

[ipatch]

here's a run with my local tap github.com/ipatch/us-05 with the default tests.yml

https://github.com/ipatch/homebrew-us-05/actions/runs/9507021513/job/26205542996

something has definitely changed upstream 🧐

[ipatch]

need to resolve the linting errors / warnings in the yaml files because PR will work.

29 files inspected, no offenses detected
.github/workflows/tests.yml:70:58: property "date" is not defined in object type {get_current_date: {conclusion: string; outcome: string; outputs: {string => string}}; print_date: {conclusion: string; outcome: string; outputs: {string => string}}; set_default_run_status: {conclusion: string; outcome: string; outputs: {string => string}}} [expression]
.github/workflows/tests.yml:84:13: property "last_run_status" is not defined in object type {get_current_date: {conclusion: string; outcome: string; outputs: {string => string}}; print_date: {conclusion: string; outcome: string; outputs: {string => string}}; restore_last_run_status: {conclusion: string; outcome: string; outputs: {string => string}}; set-up-homebrew: {conclusion: string; outcome: string; outputs: {string => string}}; set_default_run_status: {conclusion: string; outcome: string; outputs: {string => string}}; set_last_run_status: {conclusion: string; outcome: string; outputs: {string => string}}} [expression]
   |
84 |         if: steps.last_run_status.outputs.last_run_status != 'success'
   |             ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
.github/workflows/tests.yml:104:56: property "last_run_status" is not defined in object type {cache: {conclusion: string; outcome: string; outputs: {string => string}}; get_current_date: {conclusion: string; outcome: string; outputs: {string => string}}; print_date: {conclusion: string; outcome: string; outputs: {string => string}}; print_env: {conclusion: string; outcome: string; outputs: {string => string}}; restore_last_run_status: {conclusion: string; outcome: string; outputs: {string => string}}; set-up-homebrew: {conclusion: string; outcome: string; outputs: {string => string}}; set_default_run_status: {conclusion: string; outcome: string; outputs: {string => string}}; set_last_run_status: {conclusion: string; outcome: string; outputs: {string => string}}} [expression]
    |
104 |         if: steps.cache.outputs.cache-hit != 'true' && steps.last_run_status.outputs.last_run_status != 'success'
    |                                                        ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
.github/workflows/tests.yml:122:9: shellcheck reported issue in this script: SC2046:warning:6:3: Quote this to prevent word splitting [shellcheck]
    |
122 |         run: |
    |         ^~~~
.github/workflows/tests.yml:190:13: property "last_run_status" is not defined in object type {build_bottle: {conclusion: string; outcome: string; outputs: {string => string}}; cache: {conclusion: string; outcome: string; outputs: {string => string}}; debug_workflow_run: {conclusion: string; outcome: string; outputs: {string => string}}; get_current_date: {conclusion: string; outcome: string; outputs: {string => string}}; print_date: {conclusion: string; outcome: string; outputs: {string => string}}; print_env: {conclusion: string; outcome: string; outputs: {string => string}}; restore_last_run_status: {conclusion: string; outcome: string; outputs: {string => string}}; set-up-homebrew: {conclusion: string; outcome: string; outputs: {string => string}}; set_default_run_status: {conclusion: string; outcome: string; outputs: {string => string}}; set_last_run_status: {conclusion: string; outcome: string; outputs: {string => string}}; upload_bottle_artifacts: {conclusion: string; outcome: string; outputs: {string => string}}} [expression]
    |
190 |         if: steps.last_run_status.outputs.last_run_status != 'success'
    |             ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
.github/workflows/tests.yml:191:9: shellcheck reported issue in this script: SC2086:info:1:57: Double quote to prevent globbing and word splitting [shellcheck]
    |
191 |         run: echo "last_run_status=${{ steps.test_run.outcome }}" >> $GITHUB_ENV
    |         ^~~~
.github/workflows/tests.yml:191:40: property "test_run" is not defined in object type {build_bottle: {conclusion: string; outcome: string; outputs: {string => string}}; cache: {conclusion: string; outcome: string; outputs: {string => string}}; debug_workflow_run: {conclusion: string; outcome: string; outputs: {string => string}}; get_current_date: {conclusion: string; outcome: string; outputs: {string => string}}; print_date: {conclusion: string; outcome: string; outputs: {string => string}}; print_env: {conclusion: string; outcome: string; outputs: {string => string}}; restore_last_run_status: {conclusion: string; outcome: string; outputs: {string => string}}; set-up-homebrew: {conclusion: string; outcome: string; outputs: {string => string}}; set_default_run_status: {conclusion: string; outcome: string; outputs: {string => string}}; set_last_run_status: {conclusion: string; outcome: string; outputs: {string => string}}; upload_bottle_artifacts: {conclusion: string; outcome: string; outputs: {string => string}}} [expression]
    |
191 |         run: echo "last_run_status=${{ steps.test_run.outcome }}" >> $GITHUB_ENV
    |                                        ^~~~~~~~~~~~~~~~~~~~~~
.github/workflows/validate_runner_status.yml:87:9: shellcheck reported issue in this script: SC2256:warning:8:8: This translated string is the name of a variable. Flip leading $ and " if this should be a quoted substitution [shellcheck]
   |
87 |         run: |
   |         ^~~~
.github/workflows/validate_runner_status.yml:87:9: shellcheck reported issue in this script: SC2086:info:12:39: Double quote to prevent globbing and word splitting [shellcheck]
   |
87 |         run: |
   |         ^~~~
.github/workflows/validate_runner_status.yml:87:9: shellcheck reported issue in this script: SC2029:info:22:41: Note that, unescaped, this expands on the client side [shellcheck]
   |
87 |         run: |
   |         ^~~~
.github/workflows/validate_runner_status.yml:87:9: shellcheck reported issue in this script: SC2029:info:28:58: Note that, unescaped, this expands on the client side [shellcheck]
   |
87 |         run: |
   |         ^~~~
.github/workflows/validate_runner_status.yml:87:9: shellcheck reported issue in this script: SC2029:info:30:43: Note that, unescaped, this expands on the client side [shellcheck]
   |
87 |         run: |
   |         ^~~~
.github/workflows/validate_runner_status.yml:87:9: shellcheck reported issue in this script: SC2086:info:34:43: Double quote to prevent globbing and word splitting [shellcheck]
   |
87 |         run: |
   |         ^~~~