brew bump-formula-pr failure when bumping mysql version

[roshanjrajan-zip]

Output of brew config

brew config
HOMEBREW_VERSION: 4.1.2-19-g3f30030
ORIGIN: https://github.com/Homebrew/brew
HEAD: 3f3003072c8f8e0d834a1fd6cdf5066ec86607a1
Last commit: 2 hours ago
Core tap origin: https://github.com/Homebrew/homebrew-core
Core tap HEAD: 5445f28074162877ab1b99635d3dc1c49dd2233e
Core tap last commit: 2 hours ago
Core tap branch: master
Core tap JSON: 27 Jul 23:32 UTC
HOMEBREW_PREFIX: /opt/homebrew
HOMEBREW_CASK_OPTS: []
HOMEBREW_MAKE_JOBS: 12
Homebrew Ruby: 2.6.10 => /System/Library/Frameworks/Ruby.framework/Versions/2.6/usr/bin/ruby
CPU: dodeca-core 64-bit arm_blizzard_avalanche
Clang: 14.0.3 build 1403
Git: 2.41.0 => /opt/homebrew/bin/git
Curl: 7.88.1 => /usr/bin/curl
macOS: 13.4.1-arm64
CLT: 14.3.0.0.1.1679647830
Xcode: N/A
Rosetta 2: false

Output of brew doctor

brew doctor
Your system is ready to brew.

Description of issue

Trying to bump the version of the mysql from 8.0.33 to 8.0.34 but it fails when running brew bump-formula-pr

brew bump-formula-pr --url https://cdn.mysql.com/Downloads/MySQL-8.0/mysql-boost-8.0.34.tar.gz mysql --force
/System/Library/Frameworks/Ruby.framework/Versions/2.6/usr/lib/ruby/2.6.0/universal-darwin22/rbconfig.rb:21: warning: Insecure world writable dir /Users/roshan/evergreen/website in PATH, mode 040777
Warning: These open pull requests may be duplicates:
mysql-client mysql 8.1.0 https://github.com/Homebrew/homebrew-core/pull/136966
Warning: This formula has patches that may be resolved upstream.
==> Downloading https://cdn.mysql.com/Downloads/MySQL-8.0/mysql-boost-8.0.34.tar.gz
Already downloaded: /Users/roshan/Library/Caches/Homebrew/downloads/97f5caa29a4805eb53a50ed22a8392332f13dbc8ef5e1eea7e33e1457bca55e6--mysql-boost-8.0.34.tar.gz
Warning: Cannot verify integrity of '97f5caa29a4805eb53a50ed22a8392332f13dbc8ef5e1eea7e33e1457bca55e6--mysql-boost-8.0.34.tar.gz'.
No checksum was provided.
For your reference, the checksum is:
  sha256 "0b881a19bcef732cd4dbbfc8dfeb84eff61f5dfe0d9788d015d699733e0adf1f"
==> replace /^  revision \d+\n(\n(  head "))?/m with "\\2"
==> replace /https:\/\/cdn\.mysql\.com\/Downloads\/MySQL\-8\.0\/mysql\-boost\-8\.0\.33\.tar\.gz/ with "https://cdn.mysql.com/Downloads/MySQL-8.0/mysql-boost-8.0.34.tar.gz"
==> replace "ae31e6368617776b43c82436c3736900067fada1289032f3ac3392f7380bcb58" with "0b881a19bcef732cd4dbbfc8dfeb84eff61f5dfe0d9788d015d699733e0adf1f"
mysql
  * Version of `mysql-client` (8.0.33) should match version of `mysql` (8.0.34)
Error: 1 problem in 1 formula detected.
Error: `brew audit` failed!

[osalbahr]

If you supply --url it looks like you need to also supply a checksum. See brew help bump-formula-pr.

Also, what happens if you supply --version instead?

[roshanjrajan-zip]

Tried that and it continues but is hanging for the last 5 minutes....

brew bump-formula-pr mysql --version 8.0.34 --force --no-audit
Warning: These open pull requests may be duplicates:
mysql-client mysql 8.1.0 https://github.com/Homebrew/homebrew-core/pull/136966
Warning: This formula has patches that may be resolved upstream.
==> Downloading https://cdn.mysql.com/Downloads/MySQL-8.0/mysql-boost-8.0.34.tar.gz
Already downloaded: /Users/roshan/Library/Caches/Homebrew/downloads/97f5caa29a4805eb53a50ed22a8392332f13dbc8ef5e1eea7e33e1457bca55e6--mysql-boost-8.0.34.tar.gz
Warning: Cannot verify integrity of '97f5caa29a4805eb53a50ed22a8392332f13dbc8ef5e1eea7e33e1457bca55e6--mysql-boost-8.0.34.tar.gz'.
No checksum was provided.
For your reference, the checksum is:
  sha256 "0b881a19bcef732cd4dbbfc8dfeb84eff61f5dfe0d9788d015d699733e0adf1f"
==> replace /^  revision \d+\n(\n(  head "))?/m with "\\2"
==> replace /https:\/\/cdn\.mysql\.com\/Downloads\/MySQL\-8\.0\/mysql\-boost\-8\.0\.33\.tar\.gz/ with "https://cdn.mysql.com/Downloads/MySQL-8.0/mysql-boost-8.0.34.tar.gz"
==> replace "ae31e6368617776b43c82436c3736900067fada1289032f3ac3392f7380bcb58" with "0b881a19bcef732cd4dbbfc8dfeb84eff61f5dfe0d9788d015d699733e0adf1f"
==> Skipping `brew audit`
M	Formula/mysql.rb
Switched to a new branch 'bump-mysql-8.0.34'
[bump-mysql-8.0.34 8b0b3e9ea17] mysql 8.0.34
 1 file changed, 2 insertions(+), 3 deletions(-)
Username for 'https://github.com': roshanjrajan-zip

[osalbahr]

This prompt asking for your username seems to be a git/github issue. Are you able to manually modify the formula and push to a branch in your fork as per the documentation for making a PR? I recommend giving that a try. And once you’re able to do that successfully, brew bump will go through as well.

I’d expect the same “username for” to happen and hang too (or fail, since GitHub no longer supports pushing with a password). I personally set up ssh keys locally for github and have git automatically use ssh instead of https, so I don’t get the prompt to begin with.

[roshanjrajan-zip]

I have git set up to use ssh so not entirely sure why it asked for my username.

[osalbahr]

Are you able to push to a branch in your fork by following the steps in How to Open a Pull Request (and get it merged)? I recommend giving that a test run. Because, if I had to guess, formula-bump-pr was created to automate the exact same steps.

[roshanjrajan-zip]

Followed those instructions and was able to get it working! Thanks for the help!
Homebrew/homebrew-core#137865

[osalbahr]

You’re welcome, glad I could help! Was it related to ssh key setup or something else?

[roshanjrajan-zip]

Yeah it was the ssh key setup. Changed the remote ref to the ssh version and it worked!

[gromgit]

Seems like a missing feature. brew bump-formula-pr should check synced_versions_formulae.json and automatically add all other synced formulae to the bump PR:

$ grep \"mysql\" $(brew --repo homebrew/core)/synced_versions_formulae.json
  ["mysql", "mysql-client"],

[osalbahr]

Oh, I see what’s happening now. To make sure I understand correctly, the issue is that both need to be bumped in the same PR but bump-formula-pr doesn’t support that yet?

[gromgit]

Yes. See Homebrew/homebrew-core#136966, which actually supersedes this PR.

[osalbahr]

Yeah, looks like that PR manually bumped the two simultaneously, as well as two symlinks. I’ll follow this PR to see how it goes after the build error is all figured out.

I don’t know if synced formula bumping happens often enough to justify such a feature, but it does sound neat. Or at least a clearer error message.

One workaround I can think of is to bump both (skipping audit), close one of the PR’s, and rebase.

[apainintheneck]

There was a discussion about adding that feature to bump-formula-pr but it got closed eventually once discussion stalled.

• Allow to bump more than one formula at once for synced formulas brew#13502

[osalbahr]

Yeah, looks like this falls into the “good idea” category where anyone’s welcome to PR a solution since there’s already a good enough workaround.