Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unetpy support for connecting to older versions of UnetStack. #45

Open
notthetup opened this issue Feb 15, 2021 · 1 comment
Open

Unetpy support for connecting to older versions of UnetStack. #45

notthetup opened this issue Feb 15, 2021 · 1 comment
Assignees

Comments

@notthetup
Copy link
Collaborator

notthetup commented Feb 15, 2021

Currently when unet.py (> v3.1.0) tries to connect to a version of UnetStack running an older fjage (< v3.1.0), getting parameters is causes KeyError. org-arl/fjage#180 should fix the KeyError but the functionality is still missing.

This is caused by the movement of the ParameterAPI from UnetStack into fjage. The issue comes because the full names of the ParameterReq and ParameterRep messages changed in this movement. So the newer unet.py library sends a org.arl.fjage.param.ParameterReq but the older version of UnetStack expects a org.arl.unet.ParameterReq.

Previously, unet.py injected the setter and getter methods onto the AgentID class to generate those messages. Now (> fjage 1.7.0) AgentID class already has those methods but use the new org.arl.fjage.param.ParameterReq.

@notthetup
Copy link
Collaborator Author

notthetup commented Feb 15, 2021

This outlines a potential solution : #43 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants