Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resource oci_os_management_hub_managed_instance_group always triggers update on software_source_ids #2125

Open
jeliker opened this issue May 24, 2024 · 2 comments
Labels
awaiting-affected-resources Please Provide the affected resource name in description. ex. Affected resource - oci_core_instance bug

Comments

@jeliker
Copy link

jeliker commented May 24, 2024

Community Note

  • Please vote on this issue by adding a 馃憤 reaction to the original issue to help the community and maintainers prioritize this request
  • Please do not leave "+1" or "me too" comments, they generate extra noise for issue followers and do not help prioritize the request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment

Terraform Version and Provider Version

Terraform v1.5.7
on darwin_amd64
+ provider registry.terraform.io/oracle/oci v5.42.0

Affected Resource(s)

affected_resources = oci_os_management_hub_managed_instance_group

Terraform Configuration Files

# oci_os_management_hub_managed_instance_group.the_group will be updated in-place
  ~ resource "oci_os_management_hub_managed_instance_group" "the_group" {
        id                             = "ocid1.osmhmanagedinstancegroup.oc1.iad.amaaaaau75jj7vo7aadly3vcyaku47nw7gl5l77dchazdjyqpslvil4wivyq"
      ~ software_source_ids            = [
          - "ocid1.osmhsoftwaresource.oc1.iad.amaaaaaa2nbozuyabr3g6to5homb3zbfgtvmaw66fysimfaousk5iy3o7eba",
          - "ocid1.osmhsoftwaresource.oc1.iad.amaaaaaa2nbozuyavu6u4e4dbag3suvx6tgdequ7wjojmm3vtcng2p6nmkea",
          + "ocid1.osmhsoftwaresource.oc1.iad.amaaaaaa2nbozuyazm3ceshgxp47osx7j5ffp7uvbw3p3lncswtc5m4lwbpa",
          + "ocid1.osmhsoftwaresource.oc1.iad.amaaaaaa2nbozuyakef2til27gunt3wbshd33d7f6p5cgqonynzdo4mlykta",
            "ocid1.osmhsoftwaresource.oc1.iad.amaaaaaa2nbozuyaekdqajupoqh3z2m5lpce5kpp7pacpewigihhc5fmtsfq",
          + "ocid1.osmhsoftwaresource.oc1.iad.amaaaaaa2nbozuyaybfnw2tzcooojbgvkezjohwhx7rot4eoawl3662qmyna",
            "ocid1.osmhsoftwaresource.oc1.iad.amaaaaaa2nbozuyaahfaz4fmssh2bikykpv3vter6lofhtl53sg6wuklxqba",
            "ocid1.osmhsoftwaresource.oc1.iad.amaaaaaa2nbozuyaasquvgpknmndj5k4bcxsqhipxqr7de4qj4jslijz5kga",
          - "ocid1.osmhsoftwaresource.oc1.iad.amaaaaaa2nbozuyakef2til27gunt3wbshd33d7f6p5cgqonynzdo4mlykta",
          - "ocid1.osmhsoftwaresource.oc1.iad.amaaaaaa2nbozuyaybfnw2tzcooojbgvkezjohwhx7rot4eoawl3662qmyna",
          - "ocid1.osmhsoftwaresource.oc1.iad.amaaaaaa2nbozuyazm3ceshgxp47osx7j5ffp7uvbw3p3lncswtc5m4lwbpa",
            "ocid1.osmhsoftwaresource.oc1.iad.amaaaaaa2nbozuyazq4c2mi7z5zng5ap2tocbr2nqvbjnd3lcxqiralflana",
          + "ocid1.osmhsoftwaresource.oc1.iad.amaaaaaa2nbozuyavu6u4e4dbag3suvx6tgdequ7wjojmm3vtcng2p6nmkea",
          + "ocid1.osmhsoftwaresource.oc1.iad.amaaaaaa2nbozuyabr3g6to5homb3zbfgtvmaw66fysimfaousk5iy3o7eba",
        ]
        # (18 unchanged attributes hidden)

        # (1 unchanged block hidden)
    }

Plan: 0 to add, 1 to change, 0 to destroy.

Debug Output

Panic Output

Expected Behavior

Updating an oci_os_management_hub_managed_instance_group resource should not trigger change if the only variation from the previous resource is order of the software_source_ids. The order is not relevant to how the group operates and therefore can/should be allowed change without impact.

Actual Behavior

If an oci_os_management_hub_managed_instance_groupresource is updated it will always trigger a change based on the order ofsoftware_source_ids`. Notably, the order of the IDs for the resource initially created does not align to the order of the input values (via list(string)) so, as is, the order is unpredictable even if one wanted to manually re-order to avoid the issue

Steps to Reproduce

  1. terraform apply
  2. terraform apply again and note trigger to change even though nothing has changed. Is triggered only because the order of software_source_ids in the created resource now does not match what was provided on input to create the resource
  3. Manually re-order the software_source_ids input then terraform apply and note again will be prompted to accept a change (though no functional change has occurred).

Important Factoids

@jeliker jeliker added the bug label May 24, 2024
@tf-oci-pub
Copy link
Member

Thank you for reporting the issue. We observed the affected resources are not provided in the description or it's incorrect. We request you to add it in issue description as mentioned in below format.
Example: affected_resources = oci_core_instance , oci_core_instances

If it's not related to any particular resource then mention affected resource as terraform.
Example: affected_resources = terraform

As this works through automation, request you to follow exact syntax.

@tf-oci-pub tf-oci-pub added the awaiting-affected-resources Please Provide the affected resource name in description. ex. Affected resource - oci_core_instance label May 25, 2024
@jeliker jeliker changed the title Resource oci_oci_management_hub_managed_instance_group always triggers update on software_source_ids Resource oci_os_management_hub_managed_instance_group always triggers update on software_source_ids May 25, 2024
@jeliker
Copy link
Author

jeliker commented May 25, 2024

The requested affected_resources line was included from the beginning. I see I had a misspelling that has now been corrected. Is your automation telling me it did not recognize the affected_resources because of the typo?

Past experience suggests that once tagged that affected_resources is "missing" it will never be un-tagged. Is my only recourse now to duplicate this issue as a new issue?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
awaiting-affected-resources Please Provide the affected resource name in description. ex. Affected resource - oci_core_instance bug
Projects
None yet
Development

No branches or pull requests

2 participants