Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: List methods ignores limit kwarg #752

Open
4 tasks done
tanyakoganoracle opened this issue Apr 4, 2024 · 1 comment
Open
4 tasks done

[Bug]: List methods ignores limit kwarg #752

tanyakoganoracle opened this issue Apr 4, 2024 · 1 comment
Labels
ack acknowledged bug Something isn't working

Comments

@tanyakoganoracle
Copy link
Member

Oracle-ads version used

  • I have checked that this issue has not already been reported.

  • I have confirmed this bug exists on the latest version of oracle-ads.

  • I have confirmed this bug exists on the main branch of oracle-ads.

  • I agree to follow Code of Conduct.

Description

DataScienceJob.list_jobs,
ModelDeployment.list(
compartment_id=oci_environment.compartment_id,
project_id=oci_environment.project_id,
limit=15
)
This methods ignores the limit variable. Maybe another similar methods for other classes too.

How to Reproduce

ModelDeployment.list(
    compartment_id=oci_environment.compartment_id,
    project_id=oci_environment.project_id,
    limit=15
)

What was Observed

returns a lot more then 15

What was Expected

Only 15 items

Version

oracle-ads==2.8.11
@tanyakoganoracle tanyakoganoracle changed the title [Bug]: [Bug]: List methods ignores limit kwarg Apr 5, 2024
@mrDzurb
Copy link
Member

mrDzurb commented May 21, 2024

Under the hood it is used the - list_call_get_all_results API, where the limit parameter will be ignored. We will check this.

@mrDzurb mrDzurb added ack acknowledged bug Something isn't working labels May 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ack acknowledged bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants