Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add validation memory quantity for Flex shapes #62

Open
kral2 opened this issue Mar 17, 2021 · 0 comments
Open

add validation memory quantity for Flex shapes #62

kral2 opened this issue Mar 17, 2021 · 0 comments
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed
Milestone

Comments

@kral2
Copy link
Contributor

kral2 commented Mar 17, 2021

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • Please do not leave "+1" or "me too" comments, they generate extra noise for issue followers and do not help prioritize the request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment

Description

Flex shapes requires a minimum ratio of 1:1 for cpu:ram, e.g you cannot have memory quantify smaller than ocpu count.

Instead of having the module user enter wrong values and get an API error that needs to be interpreted, we can detect this misconfiguration before hitting the API and return a meaningful message to the customer.

This can saved lot of provisioning time if instance module is part of a more larger configuration and is not provisioned first.

New or Affected Resource(s)

oci_core_instance and the associated Input Variable: var.instance_flex_memory_in_gbs

Potential Terraform Configuration

No initial implementation mock-up yet.

# Copy-paste any Terraform configurations for how the requested feature may be used. 

References

https://docs.oracle.com/en-us/iaas/Content/Compute/References/computeshapes.htm#flexible

@kral2 kral2 added enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed labels Mar 17, 2021
@kral2 kral2 added this to the Future milestone Sep 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

1 participant