reduce required permissions for github auth (don't ask for private repos) #1120
-
ProblemThe OAuth flow requires permissions to all repositories, including private repositories. The oauth implementation is simple at the moment. To avoid additional logic flows of "user has given access to this repo", the implementation naively requests permissions to all repositories. Users are reporting the desire to grant access on a finer level. ProposalImplement a "per repository" auth flow. Additional informationUpvote this issue if you want this feature. This issue is not a priority at the moment. While a more fine-grained auth flow is nice to have, other features of the editor bring more value to a wider audience. |
Beta Was this translation helpful? Give feedback.
Replies: 6 comments 3 replies
-
@NilsJacobsen @NiklasBuchfink This could be a potential drop-off of users because users don't want to open up their complete Github repository. |
Beta Was this translation helpful? Give feedback.
-
This is not related to website makeover it would have been related to the editor. Why not using a checkbox and call for access of public/ public and private repos? |
Beta Was this translation helpful? Give feedback.
-
Yes, just wanted to bring this up as an idea what causes the drop-off of users be less significant. |
Beta Was this translation helpful? Give feedback.
-
The auth implementation becomes more complex because users need to re-authorize if they want to grant additional repositories permissions.
@felixhaeberle Good point. We could take a look at the drop-off between "clicked on sign in" and actual sign in. |
Beta Was this translation helpful? Give feedback.
-
I opened a second github account with limited permissions to get around this issue 😅. So it's definitely adding a bit of fiction for us, and is preventing me from inviting more of our team as editors of our repo here. Just an FYI, thanks for Inlang! |
Beta Was this translation helpful? Give feedback.
-
We have reduced the required GitHub permissions to use the editor since #1466 has been merged. Please give us feedback on the auth-flow on GitHub or in our Discord channel :) |
Beta Was this translation helpful? Give feedback.
We have reduced the required GitHub permissions to use the editor since #1466 has been merged.
Please give us feedback on the auth-flow on GitHub or in our Discord channel :)