Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

settings under change control #145

Open
samuelstroschein opened this issue Aug 26, 2024 — with Linear · 1 comment
Open

settings under change control #145

samuelstroschein opened this issue Aug 26, 2024 — with Linear · 1 comment

Comments

Copy link
Member

Context

The settings.json file is not tracked with lix atm.

  • settings should be trackable as conflicts should be raisable

Proposal

Track the settings.json file with lix.

Copy link
Member Author

samuelstroschein commented Aug 26, 2024

EDIT: nevermind. I would snapshot the settings file and store meta data for what property changed.

Ha. This is an interesting one. I am inclined to track changes in the settings.json per property instead of snapshotting the settings.json file (confirming LIX-109):

  • an app cares about "did this setting" change?
    • if the properties are stored, traversing the changes per property is easy
    • if the entire snapshot is saved, each snapshot needs to be traversed
  • merging properties is simpler than merging the entire settings file.
    • imagine settings.modules changes in A and B, we can combine settings.module from A and B.

@niklas.buchfink (building fink) @jannes.blobel (posthog settings would be the same use case) can you research how you would want to show change control for settings to the user?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant