Store timezones for TimeEntries and finalize how we determine end time #17272
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
klaustopher
force-pushed
the
add-timezone-to-time-entry
branch
from
16c2577
to
b34f384
Compare
klaustopher
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket
https://community.openproject.org/projects/stream-time-and-costs/work_packages/59466
What are you trying to accomplish?
During the discussion today we realized that it is important to also persist the timezone of the tracked time entries so that we can properly determine what the time is. We used to anticipate that we could use the user's current timezone from the preferences, but as this might change in the future and would destroy old time entries, we also need to persist the timezone.
We also deducted that we will not need an
end_timefield but it will be implied bystart_time + hours.Screenshots
What approach did you choose and why?
Merge checklist