You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Zipkin 3 comes with new interfaces such as ByteMessageSender rather than Sender that apps will need to upgrade to when upgrading from Zipkin 2 to Zipkin 3. In Zipkin 3.0, the AsyncReporter no longer supports a builder API for Sender, which prevents transitive libraries that integrate with Zipkin 2 types from being used in an app that migrates to Zipkin 3.
No deprecation of this builder API was provided in advance for users to transition away from this breaking change in 3.0.
Feature
Support a temporary/deprecated API in AsyncReporter to accept a Sender to provide a smoother migration for apps with transitive dependencies on lower versions of Zipkin that app owners cannot upgrade.
Rationale
It will help Java apps migrate from Zipkin 2 to 3. One common case is Spring Boot 3.2 to Spring Boot 3.3.
Example Scenario
Consider the case where an app has upgraded to Zipkin3, but this app may also be loading transitive libraries that are using Zipkin 2 types and creating their own Sender and AsyncReporter. When these libraries are loaded in an application that has Zipkin3 on the classpath, The Sender is accepted in the AsyncReporter builder so get an AbstractMethodError error.
Example code to illustrate this problem. A library has the following dependencies
api 'io.zipkin.reporter2:zipkin-reporter:2.10.2'
api 'io.zipkin.reporter2:zipkin-sender-okhttp3:2.10.2'
And creates their own Reporter implementation using the okttp sender.
When Zipkin 3 is on the classpath, this code throws the following error
Caused by: AbstractMethodError: Receiver class OkHttpSender does not define or inherit an implementation of the resolved method 'abstract Encoding encoding()' of interface BytesMessageSender.
at AsyncReporter$Builder.<init>(AsyncReporter.java:95)
at AsyncReporter.builder(AsyncReporter.java:55)
at AsyncReporter.builder(AsyncReporter.java:50)
at ZipkinTracingModule.reporter(ZipkinTracingModule.java:134)
The text was updated successfully, but these errors were encountered:
Zipkin 3 comes with new interfaces such as
ByteMessageSender
rather thanSender
that apps will need to upgrade to when upgrading from Zipkin 2 to Zipkin 3. In Zipkin 3.0, theAsyncReporter
no longer supports a builder API forSender
, which prevents transitive libraries that integrate with Zipkin 2 types from being used in an app that migrates to Zipkin 3.No deprecation of this builder API was provided in advance for users to transition away from this breaking change in 3.0.
Feature
Support a temporary/deprecated API in
AsyncReporter
to accept aSender
to provide a smoother migration for apps with transitive dependencies on lower versions of Zipkin that app owners cannot upgrade.Rationale
It will help Java apps migrate from Zipkin 2 to 3. One common case is Spring Boot 3.2 to Spring Boot 3.3.
Example Scenario
Consider the case where an app has upgraded to Zipkin3, but this app may also be loading transitive libraries that are using Zipkin 2 types and creating their own
Sender
andAsyncReporter
. When these libraries are loaded in an application that has Zipkin3 on the classpath, TheSender
is accepted in theAsyncReporter
builder so get anAbstractMethodError
error.Example code to illustrate this problem. A library has the following dependencies
And creates their own Reporter implementation using the okttp sender.
When Zipkin 3 is on the classpath, this code throws the following error
The text was updated successfully, but these errors were encountered: