From 46e31547ad6a030618b93ea87730c85ab519fe93 Mon Sep 17 00:00:00 2001 From: Adrian Cole Date: Wed, 13 Mar 2024 08:45:40 +0800 Subject: [PATCH] feedback Signed-off-by: Adrian Cole --- charts/zipkin/ci/helmfile.yaml | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/charts/zipkin/ci/helmfile.yaml b/charts/zipkin/ci/helmfile.yaml index d7ba629..37aa52e 100644 --- a/charts/zipkin/ci/helmfile.yaml +++ b/charts/zipkin/ci/helmfile.yaml @@ -4,9 +4,10 @@ repositories: - name: prometheus-community url: https://prometheus-community.github.io/helm-charts -# Prometheus is too much to configure manually in a test yaml. We need the CRD -# servicemonitors.monitoring.coreos.com as well as Prometheus, deployed as the -# service named "prometheus-operated" in our test namespace "ci-monitoring" +# Prometheus requires the CRD servicemonitors.monitoring.coreos.com as well as +# Prometheus, deployed as the service named "prometheus-operated" in our test +# namespace "ci-monitoring". We set this up via helm prior to running tests, as +# adding CRDs and multiple resources during a test is far more complicated. releases: - name: prometheus-stack namespace: ci-monitoring # arbitrary non-default name