Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix dyn compilation warning on Windows #930

Open
mgautierfr opened this issue Sep 2, 2024 · 0 comments
Open

Fix dyn compilation warning on Windows #930

mgautierfr opened this issue Sep 2, 2024 · 0 comments
Labels
compilation

Comments

@mgautierfr
Copy link
Collaborator

When building dll on Windows we have to specify what is exported in dll.

We already export of public symbol with __declspec(dllexport).

But we have a lot of warning as our structure/class are including std symbols and we are not exporting them.

See : kiwix/kiwix-build@d2d1f68 (#703)

One solution would be to export ALL symbols in the dll but this should probably made with a generated .def file.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
compilation
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@mgautierfr