Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Original link: undefined #106

Open
kelson42 opened this issue Apr 21, 2024 · 1 comment
Open

Original link: undefined #106

kelson42 opened this issue Apr 21, 2024 · 1 comment
Labels
bug Something isn't working question Further information is requested

Comments

@kelson42
Copy link
Contributor

image

What does mean "Original link: undefined" ?

@kelson42 kelson42 added bug Something isn't working question Further information is requested labels Apr 21, 2024
@benoit74
Copy link
Collaborator

You are not supposed to have this link displayed. Could you explain how you arrived there? Link should be something like https://library.kiwix.org/content/ifixit_fr_all_2024-03/home/unavailable_offline?url=/products/t5-torx-screwdriver (i.e. with a url query param).

Notice that the fact that iFixit is using a query parameter is now known to me to be a bad idea since it badly interact with readers especially kiwix-serve (which silently remove them from the browser URL bar). A "magic" anchor would definitely make more sense (even if it will still be a tweak, but it is widely used in JS SPA typically).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working question Further information is requested
Projects
None yet
Development

No branches or pull requests

2 participants