watchcat: allow define custom timeout

[kumy]

Maintainer: @neheb, @jtkohl
Environment: openwrt-23.05

Description:
Could we please have a way to define our own value for the ping timeout 🙏

The actual implementation uses ping without specifying the -W parameter, which defaults to 10s

packages/utils/watchcat/files/watchcat.sh

Lines 138 to 147 in dd2e710

	if [ "$iface" != "" ]; then
	ping_result="$(
	ping $ping_family -I "$iface" -s "$ping_size" -c 1 "$host" &> /dev/null
	echo $?
	)"
	else
	ping_result="$(
	ping $ping_family -s "$ping_size" -c 1 "$host" &> /dev/null
	echo $?
	)"

ping --help
[...]
	-W SEC		Seconds to wait for the first response (default 10)

Thanks a lot :)

EDIT: first draft PR #25174

[kumy]

my actual local patch is

--- /tmp/watchcat.sh.orig	2024-10-20 09:56:16.716946280 +0200
+++ /tmp/watchcat.sh.new	2024-10-20 09:55:57.417045742 +0200
@@ -137,12 +137,12 @@
 		for host in $ping_hosts; do
 			if [ "$iface" != "" ]; then
 				ping_result="$(
-					ping $ping_family -I "$iface" -s "$ping_size" -c 1 "$host" &> /dev/null
+					ping $ping_family -I "$iface" -s "$ping_size" -c 1 -W 1 "$host" &> /dev/null
 					echo $?
 				)"
 			else
 				ping_result="$(
-					ping $ping_family -s "$ping_size" -c 1 "$host" &> /dev/null
+					ping $ping_family -s "$ping_size" -c 1 -W 1 "$host" &> /dev/null
 					echo $?
 				)"
 			fi
@@ -218,12 +218,12 @@
 		for host in $ping_hosts; do
 			if [ "$iface" != "" ]; then
 				ping_result="$(
-					ping $ping_family -I "$iface" -s "$ping_size" -c 1 "$host" &> /dev/null
+					ping $ping_family -I "$iface" -s "$ping_size" -c 1 -W 1 "$host" &> /dev/null
 					echo $?
 				)"
 			else
 				ping_result="$(
-					ping $ping_family -s "$ping_size" -c 1 "$host" &> /dev/null
+					ping $ping_family -s "$ping_size" -c 1 -W 1 "$host" &> /dev/null
 					echo $?
 				)"
 			fi