Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support to iOS 14+ #16

Open
tapz opened this issue Apr 3, 2024 · 7 comments
Open

Add support to iOS 14+ #16

tapz opened this issue Apr 3, 2024 · 7 comments

Comments

@tapz
Copy link

tapz commented Apr 3, 2024

Xcode gives this error when my project has Minimum Deployment target set to 14:

Invalid Bundle. The bundle MyApp.app/Frameworks/OpenTok.framework does not support the minimum OS Version specified in the Info.plist.

OpenTok Package.swift has this:

platforms: [.iOS(.v13)],

@johnDaniul
Copy link

We are experiencing this issue as well, and it seems to be related to recent changes in XCode 15.3 and the way SPM packages are handled. This prevents publishing to Apple, as the app gets rejected on upload.

@johnDaniul
Copy link

Some further information, as this isn't the only library to have this issue recently. It looks like SPM libraries that distribute binary versions need to make sure to include MinimumOSVersion key in their Info.plist file. This value is now required when building on XCode 15.3 and submitting to Apple. It seems to be generated automatically for SPM libraries that distribute code only, but needs to be manually added into the binary builds.

@v-kpheng
Copy link
Collaborator

v-kpheng commented Jul 15, 2024

Apologies for the belated reply. We're investigating this now: https://jira.vonage.com/browse/VIDCS-2459.

We're We are not able to reproduce, though. Using Xcode 15.4 with minimum target 16.4, we were able to upload to TestFlight just fine.

We might be missing something though. Any ideas? Thanks!

@n8sters
Copy link

n8sters commented Aug 7, 2024

As far as I can tell this is specifically on Xcode 15.3, not 15.4. We were having issue updating to 15.4 so we're all kept on 15.3, which is still experiencing the issue. Out min supported version is 16, moving to 17 in a few months. I'm going to investigate moving back to 15.4 since I believe our issues have been resolved, but cannot say for certain yet.

@n8sters
Copy link

n8sters commented Aug 7, 2024

Ok confirmed this is isolated to Xcode 15.3. I tested 15.4 and the issue hitting our team has been resolved so we're updating to use that version, but any dev locked to 15.3 won't be able to use this SDK without some issues if they have a 14.+ min version support.

@v-kpheng
Copy link
Collaborator

v-kpheng commented Aug 7, 2024

Thanks, @n8sters.

Let me ask Engineering if they can reproduce with 15.3.

@n8sters
Copy link

n8sters commented Aug 7, 2024

Cool cool. I saved the debug log printouts so if you end up needing that just ping me and I can email some snippets over.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants