-
Notifications
You must be signed in to change notification settings - Fork 923
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Alternatives to popup windows for social sharing #5414
Comments
That's what already happens on small screens. If you do Bootstrap modal, it probably won't. |
I certainly agree with that - in my case it was opening in the opposite corner of my monitor to the main window. Plus popups are pretty rare on the web these days so it will just surprise people in general I think. So I'm certainly interested in what the alternatives are. |
Popups were chosen initially, inspired by rails-social-share-button, which is now deprecated. I didn't thought too much about alternatives at the time. To be honest, I’m not a fan of popups either. Refactoring to open links in new tabs would probably simplify the code and make maintenance easier. For the other alternatives, using Bootstrap modals with iframes likely won’t work due to CSP restrictions on most websites. While the Web Share API is promising, it’s not yet widely supported. Opening links in new tabs seems like the cleanest and most maintainable solution in my opinion. I would be eager to do a refactor if there is agreement on the approach. |
Anyone who wants new tabs can already open the links in new tabs by middle-clicking. |
I think that using a popup window for the social sharing functionality isn't a great user experience, but I would like to have a more detailed discussion about the pros and cons.
In my mind, either one of these would be preferable:
What do other people think? Why were popups originally chosen?
cc @kcne
The text was updated successfully, but these errors were encountered: