You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
When the screen is too narrow to display the 'compact-nav' list of menus (namely: logo+primary-nav+compact-secondary-nav+(user_menu or login_menu)), we switch to the 'small-nav' setup, with just the logo and the "burger" menu button.
However, this breakpoint depends on the calculated width of the menu items, not the width of the screen. It means that some features, like the edit button and the export button, are disabled based on the length of certain strings, rather than the screen width. Even in English, this means it depends on the length of the user's display name:
I think it's reasonable to show the edit button, even in the 'small-nav' menu, for a screen width of over 1100 pixels!
Even without the silly name, the point still stands, particularly for languages where the four labels (edit, history, export, more) might be significantly different widths from in English. And it will also impact English, if we ever add or remove buttons from the primary menu.
We should decide what minimum width is appropriate for each tool, and hide (or disable) the buttons based on the screen width, instead of the menu width.
The text was updated successfully, but these errors were encountered:
The obvious choice for small-to-compact breakpoint is 768px. Sidebars switch at this breakpoint. However the header ui (logo + edit + history + export + more + login + signup) still doesn't fit into this size with some localizations. This doesn't depend on the username because it happens when logged out.
I think the Export button should be moved to the secondary nav where it can collapse into More. #351 already did something like this long ago. The only reason for Export to stay as a button is that it opens a map and other secondary nav items don't. But that's their current implementation, I can imagine GPS Traces opening a map.
When the screen is too narrow to display the 'compact-nav' list of menus (namely: logo+primary-nav+compact-secondary-nav+(user_menu or login_menu)), we switch to the 'small-nav' setup, with just the logo and the "burger" menu button.
However, this breakpoint depends on the calculated width of the menu items, not the width of the screen. It means that some features, like the edit button and the export button, are disabled based on the length of certain strings, rather than the screen width. Even in English, this means it depends on the length of the user's display name:
I think it's reasonable to show the edit button, even in the 'small-nav' menu, for a screen width of over 1100 pixels!
Even without the silly name, the point still stands, particularly for languages where the four labels (edit, history, export, more) might be significantly different widths from in English. And it will also impact English, if we ever add or remove buttons from the primary menu.
We should decide what minimum width is appropriate for each tool, and hide (or disable) the buttons based on the screen width, instead of the menu width.
The text was updated successfully, but these errors were encountered: