Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error disabling timeout #1579

Open
AndrewHess opened this issue Dec 5, 2022 · 4 comments
Open

Error disabling timeout #1579

AndrewHess opened this issue Dec 5, 2022 · 4 comments
Labels

Comments

@AndrewHess
Copy link

AndrewHess commented Dec 5, 2022

Describe the bug
When I try to disable the timeout for the connection to my keyboard, I get an error and the timeout remains enabled. The following is logged to plover.log

2022-12-05 16:17:33,746 [Dummy-1] ERROR: engine update failed
Traceback (most recent call last):
  File "/Users/runner/work/plover/plover/build/osxapp/Plover.app/Contents/Frameworks/Python.framework/Versions/Current/lib/python3.9/site-packages/plover/engine.py", line 147, in run
  File "/Users/runner/work/plover/plover/build/osxapp/Plover.app/Contents/Frameworks/Python.framework/Versions/Current/lib/python3.9/site-packages/plover/engine.py", line 189, in _update
  File "/Users/runner/work/plover/plover/build/osxapp/Plover.app/Contents/Frameworks/Python.framework/Versions/Current/lib/python3.9/site-packages/plover/config.py", line 396, in update
  File "/Users/runner/work/plover/plover/build/osxapp/Plover.app/Contents/Frameworks/Python.framework/Versions/Current/lib/python3.9/site-packages/plover/config.py", line 202, in validate
TypeError: float() argument must be a string or a number, not 'NoneType'

To Reproduce

  1. From the Plover UI go to Configure -> Machine
  2. Select GeminiPR for the machine
  3. In options, scroll to timeout and disable the "Use timeout" field
  4. Select Ok to apply the change

This gives a error message, and reopening that setting page shows the timeout is still enabled.

Expected behavior
The timeout should be disabled.

The reason I want to do this is so that I won't need to manually reconnect my machine every time I log into my computer. But I had trouble finding documentation on this Timeout setting, so if this doesn't do what I suspect, I'm open to alternatives.

Operating system
MacOS 13.0
Plover 4.0.0dev12

Keyboard
Moonlander Mark 1 from ZSA

@AndrewHess AndrewHess added the bug label Dec 5, 2022
@Peter-Col
Copy link

Hi Andrew, I’m encountering the same issue - did you find a solution?

@AndrewHess
Copy link
Author

Nope I haven't

@Peter-Col
Copy link

Peter-Col commented Aug 14, 2023 via email

@user202729
Copy link
Member

I don't think that "timeout" value is what allows reconnecting the machine on sleep.

Maybe refer to #1560 . (I haven't looked at those.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants