Skip to content

Latest commit

 

History

History
72 lines (43 loc) · 3.65 KB

CONTRIBUTING.rst

File metadata and controls

72 lines (43 loc) · 3.65 KB
Raw

Contributing to the Open Cultuur Data API

Want to get involved with the Open Cultuur Data API? Here's how you can help!

Please take a moment to review this document in order to make the contribution process easy and effective for everyone involved.

Using the issue tracker

The issue tracker is the preferred channel for submitting bug reports, feature requests and pull requests.

Bug reports

Spot an error in the way data is formatted? Getting unexpected error when making a call to the API? Than please submit a bug report. Good bug reports are extremely helpful in order to improve the code, and the project in general.

Some guidelines when submitting a bug report:

  • Check if the issue hasn't already been reported.
  • Be as detailed as possible, people reading the report shouldn't have to chase you up for more information. Describe the problem thoroughly, so others can try to reproduce it.
  • Verify that the problem only occurs within the Open Cultuur Data API, and not in the original source. You can do this by requesting the original document(s) via the REST API (/(source_id)/(object_id)/source). Problems in the source data will not be fixed by us and should be reported to the data publishers.

Feature requests

Feature requests are welcome, but take a moment to find out whether your idea fits the scope and goals of the project. It's up to you to make a strong case to convince others of the merits of the feature your are requesting. Please provide as much detail and context as possible.

Pull requests

We really like to receive good pull requests for patches, new features or improvements.

Our advice is to first discuss changes, before you start working on a large pull-request (for instance, when implementing new features or significant refactoring of the code). Otherwise you risk spending time on something that won't be (directly) merged into the project.

Please adhere to the :ref:`dev_coding_conventions` used throughout the project. Make sure that your pull request includes proper tests (and that they pass) and documentation.

To submit a pull request, follow this process:

  1. Fork the project and clone your fork:

    $ git clone https://github.com/<your-username>/open-cultuur-data.git
$ cd open-cultuur-data
$ git remote add upstream https://github.com/openstate/open-cultuur-data.git

  2. Always make sure you are working with a recent version. To get the latest changes from upstream:

    $ git checkout master
$ git pull upstream master

  3. Create a new topic branch (off the main project development branch) to contain your feature, change, or fix:

    $ git checkout -b <topic-branch-name>

  4. Push your topic branch up to your fork:

    $ git push origin <topic-branch-name>

  5. When you've finished writing your awesome additions to the OpenCultuurData API, please make sure you merge with the upstream dev branch before you submit your pull request, in order to prevent us from running into massive merge conflict resolutions:

    $ git pull upstream dev

  6. Open a Pull Request with a clear title and description against the dev branch.

Code formatting

  • We currently target Python 2.7 as a minimum version
  • Follow the style you see used in the primary repository! Consistency with the rest of the project always trumps other considerations.
  • The PEP 8 styleguide is used for all Python code.