From 4e94b80e130d2227f35f5b3d205adfc63521b123 Mon Sep 17 00:00:00 2001
From: Reuven Gonzales <reuven@karibalabs.co>
Date: Sun, 9 Jun 2024 18:17:45 +0100
Subject: [PATCH] Attempts to set the correct readonly values (#1607)

---
 ops/helm-charts/oso-dagster/Chart.yaml             | 2 +-
 ops/helm-charts/oso-dagster/templates/_helpers.tpl | 2 +-
 ops/helm-charts/oso-dagster/values.yaml            | 1 -
 ops/k8s-apps/base/dagster/dagster.yaml             | 2 ++
 4 files changed, 4 insertions(+), 3 deletions(-)

diff --git a/ops/helm-charts/oso-dagster/Chart.yaml b/ops/helm-charts/oso-dagster/Chart.yaml
index 2a760a0ff..99241474a 100644
--- a/ops/helm-charts/oso-dagster/Chart.yaml
+++ b/ops/helm-charts/oso-dagster/Chart.yaml
@@ -3,7 +3,7 @@ name: oso-dagster
 description: Extension of the dagster template
 
 type: application
-version: 0.1.10
+version: 0.1.11
 appVersion: "1.0.0"
 dependencies:
 - name: dagster
diff --git a/ops/helm-charts/oso-dagster/templates/_helpers.tpl b/ops/helm-charts/oso-dagster/templates/_helpers.tpl
index e727c1043..87d766aa7 100644
--- a/ops/helm-charts/oso-dagster/templates/_helpers.tpl
+++ b/ops/helm-charts/oso-dagster/templates/_helpers.tpl
@@ -31,5 +31,5 @@ postgres_db:
 {{- $name := default "webserver" .Values.dagsterWebserver.nameOverride -}}
 {{- $fullname := include "dagster.fullname" . -}}
 {{- printf "%s-%s" $fullname  $name | trunc 63 | trimSuffix "-" -}}
-{{- if .webserverReadOnly -}} --read-only {{- end -}}
+{{- if .webserverReadOnly -}} -read-only {{- end -}}
 {{- end -}}
\ No newline at end of file
diff --git a/ops/helm-charts/oso-dagster/values.yaml b/ops/helm-charts/oso-dagster/values.yaml
index 4e57cfc47..9ad316aec 100644
--- a/ops/helm-charts/oso-dagster/values.yaml
+++ b/ops/helm-charts/oso-dagster/values.yaml
@@ -8,7 +8,6 @@ dagster:
   postgresql:
     enabled: false
     postgresqlPassword: "gcp:secretmanager:dagster-db-password/versions/1"
-  enableReadOnly: true
 
 configMap:
   name: "dagster-extra-env-config-map"
diff --git a/ops/k8s-apps/base/dagster/dagster.yaml b/ops/k8s-apps/base/dagster/dagster.yaml
index 91deee4cb..4b033c215 100644
--- a/ops/k8s-apps/base/dagster/dagster.yaml
+++ b/ops/k8s-apps/base/dagster/dagster.yaml
@@ -35,6 +35,8 @@ spec:
       pythonLogs:
         pythonLogLevel: "INFO"
       nameOverride: "dagster"
+      dagsterWebserver:
+        enableReadOnly: true
       ingress:
         enabled: true
         ingressClassName: ingress-internal-cloudflare