Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OADP 4.18-dev-preview disables OpenShiftPodSecurityAdmission featuregate #58200

Merged

Conversation

kaovilai
Copy link
Member

@kaovilai kaovilai commented Oct 25, 2024

We're using FEATURE_GATES env of https://steps.ci.openshift.org/workflow/optional-operators-ci-aws to do this.

Outdated descriptions from prior iterations

reverse of https://github.com//pull/57404 for disabling feature gate and apply to 4.18-dev-preview of oadp-operator

temp workaround for openshift/oadp-operator#1555 and to start 4.18 GA LTS equivalent early.

4b9a2d6

Alternatives include labeling namespaces which would require modification to our e2e sample apps test suite.

This is to test anticipated 4.18 which would have this featuregate disabled by default per https://issues.redhat.com/browse/OCPSTRAT-487

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 25, 2024
Copy link
Contributor

openshift-ci bot commented Oct 25, 2024

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@openshift-ci openshift-ci bot added the do-not-merge/invalid-owners-file Indicates that a PR should not merge because it has an invalid OWNERS file in it. label Oct 25, 2024
Copy link
Contributor

@openshift-ci openshift-ci bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kaovilai: 1 invalid OWNERS file

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@@ -0,0 +1 @@
ci-operator/config/openshift/oadp-operator/OWNERS
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cannot parse file: open /var/tmp/gitrepo2380991326/ci-operator/step-registry/oadp/ipi/featuregate/OWNERS: no such file or directory.

@openshift-ci-robot
Copy link
Contributor

@kaovilai, pj-rehearse: unable to determine affected jobs. This could be due to a branch that needs to be rebased. ERROR:

could not determine changed registry steps: could not load step registry: file /var/tmp/gitrepo3082129494/ci-operator/step-registry/oadp/ipi/featuregate/oadp-installer-disable-featuregate-chain.metadata.json has incorrect prefix. Prefix should be oadp-ipi-featuregate
Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 5 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 10 rehearsals
Comment: /pj-rehearse max to run up to 25 rehearsals
Comment: /pj-rehearse auto-ack to run up to 5 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse abort to abort all active rehearsals
Comment: /pj-rehearse network-access-allowed to allow rehearsals of tests that have the restrict_network_access field set to false. This must be executed by an openshift org member who is not the PR author

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

@kaovilai kaovilai force-pushed the featureGateDisable-4.18-oadp branch from 29c75d2 to 4b9a2d6 Compare October 25, 2024 20:39
@openshift-ci openshift-ci bot removed the do-not-merge/invalid-owners-file Indicates that a PR should not merge because it has an invalid OWNERS file in it. label Oct 25, 2024
@openshift-ci-robot
Copy link
Contributor

@kaovilai, pj-rehearse: unable to determine affected jobs. This could be due to a branch that needs to be rebased. ERROR:

could not determine changed registry steps: could not load step registry: file /var/tmp/gitrepo1952683425/ci-operator/step-registry/oadp/ipi/disable-featuregate/oadp-installer-disable-featuregate-chain.metadata.json has incorrect prefix. Prefix should be oadp-ipi-disable-featuregate
Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 5 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 10 rehearsals
Comment: /pj-rehearse max to run up to 25 rehearsals
Comment: /pj-rehearse auto-ack to run up to 5 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse abort to abort all active rehearsals
Comment: /pj-rehearse network-access-allowed to allow rehearsals of tests that have the restrict_network_access field set to false. This must be executed by an openshift org member who is not the PR author

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

@kaovilai kaovilai force-pushed the featureGateDisable-4.18-oadp branch from 4b9a2d6 to ccdf4be Compare October 25, 2024 20:52
@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 25, 2024
@kaovilai
Copy link
Member Author

/pj-rehearse auto-ack

@openshift-ci-robot
Copy link
Contributor

@kaovilai: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@kaovilai kaovilai marked this pull request as ready for review October 25, 2024 20:55
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 25, 2024
Copy link
Contributor

@weshayutin weshayutin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/LGTM

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Oct 25, 2024
@kaovilai
Copy link
Member Author

force push incoming

make ci-operator-config

@kaovilai kaovilai force-pushed the featureGateDisable-4.18-oadp branch from ccdf4be to ac59136 Compare October 25, 2024 20:59
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Oct 25, 2024
@kaovilai
Copy link
Member Author

/pj-rehearse auto-ack

@openshift-ci-robot
Copy link
Contributor

@kaovilai: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@kaovilai
Copy link
Member Author

oh wait...

@kaovilai
Copy link
Member Author

more f...
need to set FEATURE_SET

@kaovilai kaovilai force-pushed the featureGateDisable-4.18-oadp branch from ac59136 to 9023fb0 Compare October 25, 2024 21:03
@openshift-ci-robot
Copy link
Contributor

[REHEARSALNOTIFIER]
@kaovilai: the pj-rehearse plugin accommodates running rehearsal tests for the changes in this PR. Expand 'Interacting with pj-rehearse' for usage details. The following rehearsable tests have been affected by this change:

Test name Repo Type Reason
pull-ci-openshift-oadp-operator-master-4.18-dev-preview-e2e-test-aws openshift/oadp-operator presubmit Ci-operator config changed
periodic-ci-openshift-oadp-operator-master-4.18-dev-preview-e2e-test-aws-periodic N/A periodic Ci-operator config changed
Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 5 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 10 rehearsals
Comment: /pj-rehearse max to run up to 25 rehearsals
Comment: /pj-rehearse auto-ack to run up to 5 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse abort to abort all active rehearsals
Comment: /pj-rehearse network-access-allowed to allow rehearsals of tests that have the restrict_network_access field set to false. This must be executed by an openshift org member who is not the PR author

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

@kaovilai
Copy link
Member Author

/pj-rehearse auto-ack

@openshift-ci-robot
Copy link
Contributor

@kaovilai: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@openshift-ci-robot openshift-ci-robot added the rehearsals-ack Signifies that rehearsal jobs have been acknowledged label Oct 26, 2024
Copy link
Contributor

@weshayutin weshayutin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/LGTM

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Oct 26, 2024
Copy link
Contributor

openshift-ci bot commented Oct 26, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kaovilai, weshayutin

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link
Contributor

openshift-ci bot commented Oct 26, 2024

@kaovilai: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot bot merged commit 47bfeb8 into openshift:master Oct 26, 2024
15 checks passed
kaovilai added a commit to kaovilai/release that referenced this pull request Oct 27, 2024
ptalgulk01 pushed a commit to ptalgulk01/release that referenced this pull request Oct 29, 2024
ptalgulk01 pushed a commit to ptalgulk01/release that referenced this pull request Oct 29, 2024
obochan-rh pushed a commit to obochan-rh/release that referenced this pull request Oct 31, 2024
obochan-rh pushed a commit to obochan-rh/release that referenced this pull request Oct 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. rehearsals-ack Signifies that rehearsal jobs have been acknowledged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants