-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OADP 4.18-dev-preview disables OpenShiftPodSecurityAdmission
featuregate
#58200
OADP 4.18-dev-preview disables OpenShiftPodSecurityAdmission
featuregate
#58200
Conversation
Skipping CI for Draft Pull Request. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@kaovilai: 1 invalid OWNERS file
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.
@@ -0,0 +1 @@ | |||
ci-operator/config/openshift/oadp-operator/OWNERS |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cannot parse file: open /var/tmp/gitrepo2380991326/ci-operator/step-registry/oadp/ipi/featuregate/OWNERS: no such file or directory.
@kaovilai,
Interacting with pj-rehearseComment: Once you are satisfied with the results of the rehearsals, comment: |
29c75d2
to
4b9a2d6
Compare
@kaovilai,
Interacting with pj-rehearseComment: Once you are satisfied with the results of the rehearsals, comment: |
4b9a2d6
to
ccdf4be
Compare
/pj-rehearse auto-ack |
@kaovilai: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/LGTM
force push incoming
|
ccdf4be
to
ac59136
Compare
/pj-rehearse auto-ack |
@kaovilai: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
oh wait... |
more f... |
ac59136
to
9023fb0
Compare
[REHEARSALNOTIFIER]
Interacting with pj-rehearseComment: Once you are satisfied with the results of the rehearsals, comment: |
/pj-rehearse auto-ack |
@kaovilai: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/LGTM
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: kaovilai, weshayutin The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@kaovilai: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
We're using FEATURE_GATES env of https://steps.ci.openshift.org/workflow/optional-operators-ci-aws to do this.
Outdated descriptions from prior iterations
reverse of https://github.com//pull/57404 for disabling feature gate and apply to 4.18-dev-preview of oadp-operator
temp workaround for openshift/oadp-operator#1555 and to start 4.18 GA LTS equivalent early.
4b9a2d6
Alternatives include labeling namespaces which would require modification to our e2e sample apps test suite.
This is to test anticipated 4.18 which would have this featuregate disabled by default per https://issues.redhat.com/browse/OCPSTRAT-487