Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

duplicating all unit/integration tests for aws plugin for legacy-aws plugin #1572

Open
kaovilai opened this issue Oct 24, 2024 · 1 comment
Open

duplicating all unit/integration tests for aws plugin for legacy-aws plugin #1572

kaovilai opened this issue Oct 24, 2024 · 1 comment

Comments

@kaovilai
Copy link
Member 

          This fixes related issue, but I would also suggest duplicating all unit/integration tests for aws plugin for legacy-aws plugin

Originally posted by @mateusoliveira43 in #1568 (review)
@sseago
Copy link
Contributor

sseago commented Oct 24, 2024

Original implementation PR added some unit tests. I'm not sure we want to duplicate all tests, but it wouldn't hurt to look at the current unit tests and determine whether more are needed for legacy-aws.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@sseago @kaovilai