Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updating the log level in NROP CR doesn't affect log level of the controller pod of the operator #921

Open
shajmakh opened this issue Apr 10, 2024 · 2 comments · May be fixed by #1022
Open

Updating the log level in NROP CR doesn't affect log level of the controller pod of the operator #921

shajmakh opened this issue Apr 10, 2024 · 2 comments · May be fixed by #1022

Comments

@shajmakh
Copy link
Member

The log-level Trace comes in handy for debugging when one needs to increase verbosity. However, NROP CR update only updates the log level of the RTE and not the controller pod, although there are logs that need increased verbosity to be shown.
@ffromani
Copy link
Member

unfortunately we can't solve this easily because we would need to change the command line flags of the operator binary, which are controllerd by the Deployment which are owned by the OLM. The only alternative which comes to mind is to have a override configuration file, but this seems a lot of work for this task

@ffromani
Copy link
Member

we can add a top-level optional field in NUMAResourcesOperator and change the log level dynamically.

But we need to make sure this works with klog (it should) but also with structured logging, which means with logr.

@ffromani ffromani linked a pull request Sep 24, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

WIP: adjust the operator log level programmatically openshift-kni/numaresources-operator
2 participants
@ffromani @shajmakh