Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multiple binding schemas per plan #727

Open
sgran opened this issue Sep 14, 2020 · 3 comments
Open

Multiple binding schemas per plan #727

sgran opened this issue Sep 14, 2020 · 3 comments
Assignees
Labels

Comments

@sgran
Copy link

sgran commented Sep 14, 2020

What is the problem?
Currently only one schema for binding is available per plan, with an opaque map of parameters. This makes it difficult to create opinionated binding types, for example when there are multiple levels of access available for a service.

Who does this affect?
Service broker authors

Do you have any proposed solutions?
Multiple binding schemas per plan, or perhaps a better name might be binding plans.

Additional context
Many services have at least the concept of read vs write as access levels to the service, and many have additional levels of granularity (can write data but not update schemas, can write data for insert but not update, can create users but not admin users, etc). As part of offering a binding to these services, it makes sense to offer prescriptive plans that encapsulate the access levels to enforce consistency in the offering.

@sgran
Copy link
Author

sgran commented Sep 15, 2020

Thinking about this, I suppose it should be possible to offer alternative plans with a OneOf construct in the schema, but I think it makes validation harder than it needs to be, and probably makes it quite difficult for people building UIs programatically from the schema.

@Samze Samze self-assigned this Sep 15, 2020
@Samze
Copy link
Contributor

Samze commented Sep 15, 2020

Thanks for raising this @sgran!

We are generally hesitant to add multiple bindings schemas as it brings added complexity to the spec and additional work for platforms - platforms would need to validate against the current spec defined schema and then a list of additional schemas.

I think the idea of binding plans is an interesting one, but given there is already a workable solution with OneOf and adding multiple bindings would add extra complexity to the spec, I think we would have to see more requests for this feature.

Happy to keep this issue open for discussion in v3 and for further comments.

@lelvisl
Copy link

lelvisl commented Sep 9, 2022

Same problem when I want to serve different types of bindings on one service instance - https://github.com/openservicebrokerapi/servicebroker/blob/v2.17/spec.md#types-of-binding.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Inbox
Development

No branches or pull requests

4 participants