Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

create_standalone_connector() should be create_connector() #396

Open
rbpasker opened this issue Jun 28, 2024 · 1 comment
Open

create_standalone_connector() should be create_connector() #396

rbpasker opened this issue Jun 28, 2024 · 1 comment
Labels
enhancement New feature or request

Comments

@rbpasker
Copy link

there are two kinds of connectors: standalone and those bound to a specific model. The former uses this API, and the latter uses the Model API. Since they're in two different interfaces, this one is not ambiguous and should not need the word 'standalone' in the definition.

for backwards compatibility, i recommend adding @depricated to create_standalone_connector(), and then invoking create_connector():

    @deprecated("Use create_connector instead")
    def create_standalone_connector(self, payload: dict):
        return self.create_connector(**args, **kwargs)

def create_standalone_connector(self, payload: dict):

@dblock
Copy link
Member

dblock commented Jul 22, 2024

Thanks for opening this @rbpasker, want to try and contribute the change as suggested?

[Catch All Triage w/ 1, 2, 3]

@dblock dblock added enhancement New feature or request and removed untriaged labels Jul 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants