Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] query_insights tests flaky #714

Open
dblock opened this issue Dec 9, 2024 · 1 comment
Open

[BUG] query_insights tests flaky #714

dblock opened this issue Dec 9, 2024 · 1 comment
Labels
bug Something isn't working flaky test help wanted Extra attention is needed

Comments

@dblock
Copy link
Member

dblock commented Dec 9, 2024

What is the bug?

From https://github.com/opensearch-project/opensearch-api-specification/actions/runs/12242182451/job/34148934118?pr=711

FAILED  insights/top_queries.yaml (tests/plugins/query_insights/insights/top_queries.yaml)
    FAILED  CHAPTERS
        PASSED  Retrieve default top queries.
            PASSED  REQUEST BODY
            PASSED  RESPONSE STATUS
            PASSED  RESPONSE PAYLOAD BODY
            PASSED  RESPONSE PAYLOAD SCHEMA
            SKIPPED RESPONSE OUTPUT VALUES
        FAILED  Retrieve top queries by latency.
            PASSED  PARAMETERS
                PASSED  type
            PASSED  REQUEST BODY
            PASSED  RESPONSE STATUS
            PASSED  RESPONSE PAYLOAD BODY
            FAILED  RESPONSE PAYLOAD SCHEMA (data/top_queries/0/source/query/bool/must/0/match/title/zero_terms_query MUST be equal to one of the allowed values: all, none, data/top_queries/0/source/query/bool/must must be object, data/top_queries/0/source/query/bool/must must be object, data/top_que, ...)

How can one reproduce the bug?

Unclear.

What is the expected behavior?

Tests to pass consistently.

What is your host/environment?

CI/CD GHA

Do you have any screenshots?

Screenshot 2024-12-09 at 1 48 38 PM

Do you have any additional context?

Likely a response that varies if you query too slow/fast/out of order.

@dblock dblock added the bug Something isn't working label Dec 9, 2024
@dblock dblock added help wanted Extra attention is needed flaky test and removed untriaged labels Dec 9, 2024
@dblock
Copy link
Member Author

dblock commented Dec 16, 2024

@ansjcy if you have any idea what this API intermittently returns that doesn't match the spec (a null?) and can correct it, that would be much appreciated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working flaky test help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

1 participant