From c42554e17aded55eecb9014ee2c4df288e748988 Mon Sep 17 00:00:00 2001 From: Vacha Shah Date: Tue, 8 Nov 2022 10:57:43 -0800 Subject: [PATCH] Update documentation (#54) * Updating repo documentation Signed-off-by: Vacha Shah * Add maintainers Signed-off-by: Vacha Shah * Adding CODEOWNERS Signed-off-by: Vacha Shah * Update Maintainers Signed-off-by: Vacha Shah Signed-off-by: Vacha Shah --- .github/CODEOWNERS | 1 + ADMINS.md | 8 ++++ CONTRIBUTING.md | 106 +++++++++++++++++++++++++++-------------- DEVELOPER_GUIDE.md | 6 +-- LICENSE => LICENSE.txt | 0 MAINTAINERS.md | 19 ++++++++ NOTICE | 1 - NOTICE.txt | 2 + README.md | 1 + SECURITY.md | 3 ++ 10 files changed, 106 insertions(+), 41 deletions(-) create mode 100644 .github/CODEOWNERS create mode 100644 ADMINS.md rename LICENSE => LICENSE.txt (100%) create mode 100644 MAINTAINERS.md delete mode 100644 NOTICE create mode 100644 NOTICE.txt create mode 100644 SECURITY.md diff --git a/.github/CODEOWNERS b/.github/CODEOWNERS new file mode 100644 index 000000000..1b648abd0 --- /dev/null +++ b/.github/CODEOWNERS @@ -0,0 +1 @@ +* @abhivka7 @dblock @harshavamsi @pgtgrly @sachetalva @nhtruong @Xtansia @VachaShah diff --git a/ADMINS.md b/ADMINS.md new file mode 100644 index 000000000..7b467bfde --- /dev/null +++ b/ADMINS.md @@ -0,0 +1,8 @@ +## Admins + +| Admin | GitHub ID | Affiliation | +| -------------------------| --------------------------------------- | ----------- | +| Charlotte Henkle | [CEHENKLE](https://github.com/cehenkle) | Amazon | +| Henri Yandell | [hyandell](https://github.com/hyandell) | Amazon | + +[This document](https://github.com/opensearch-project/.github/blob/main/ADMINS.md) explains what admins do in this repo. and how they should be doing it. If you're interested in becoming a maintainer, see [MAINTAINERS](MAINTAINERS.md). If you're interested in contributing, see [CONTRIBUTING](CONTRIBUTING.md). diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md index c4b6a1c50..4c471a813 100644 --- a/CONTRIBUTING.md +++ b/CONTRIBUTING.md @@ -1,59 +1,91 @@ -# Contributing Guidelines +- [Contributing to OpenSearch](#contributing-to-opensearch) +- [First Things First](#first-things-first) +- [Ways to Contribute](#ways-to-contribute) + - [Bug Reports](#bug-reports) + - [Feature Requests](#feature-requests) + - [Contributing Code](#contributing-code) +- [Developer Certificate of Origin](#developer-certificate-of-origin) +- [Review Process](#review-process) -Thank you for your interest in contributing to our project. Whether it's a bug report, new feature, correction, or additional -documentation, we greatly value feedback and contributions from our community. +## Contributing to OpenSearch -Please read through this document before submitting any issues or pull requests to ensure we have all the necessary -information to effectively respond to your bug report or contribution. +OpenSearch is a community project that is built and maintained by people just like **you**. We're glad you're interested in helping out. There are several different ways you can do it, but before we talk about that, let's talk about how to get started. +## First Things First -## Reporting Bugs/Feature Requests +1. **When in doubt, open an issue** - For almost any type of contribution, the first step is opening an issue. Even if you think you already know what the solution is, writing down a description of the problem you're trying to solve will help everyone get context when they review your pull request. If it's truly a trivial change (e.g. spelling error), you can skip this step -- but as the subject says, when it doubt, [open an issue](https://github.com/opensearch-project/opensearch-api-specification/issues/new/choose). -We welcome you to use the GitHub issue tracker to report bugs or suggest features. +2. **Only submit your own work** (or work you have sufficient rights to submit) - Please make sure that any code or documentation you submit is your work or you have the rights to submit. We respect the intellectual property rights of others, and as part of contributing, we'll ask you to sign your contribution with a "Developer Certificate of Origin" (DCO) that states you have the rights to submit this work and you understand we'll use your contribution. There's more information about this topic in the [DCO section](#developer-certificate-of-origin). -When filing an issue, please check existing open, or recently closed, issues to make sure somebody else hasn't already -reported the issue. Please try to include as much information as you can. Details like these are incredibly useful: +## Ways to Contribute -* A reproducible test case or series of steps -* The version of our code being used -* Any modifications you've made relevant to the bug -* Anything unusual about your environment or deployment +### Bug Reports +Ugh! Bugs! -## Contributing via Pull Requests -Contributions via pull requests are much appreciated. Before sending us a pull request, please ensure that: +A bug is when software behaves in a way that you didn't expect and the developer didn't intend. To help us understand what's going on, we first want to make sure you're working from the latest version. -1. You are working against the latest source on the *main* branch. -2. You check existing open, and recently merged, pull requests to make sure someone else hasn't addressed the problem already. -3. You open an issue to discuss any significant work - we would hate for your time to be wasted. +Once you've confirmed that the bug still exists in the latest version, you'll want to check to make sure it's not something we already know about on the [open issues GitHub page](https://github.com/opensearch-project/opensearch-api-specification/issues/new/choose). -To send us a pull request, please: +If you've upgraded to the latest version and you can't find it in our open issues list, then you'll need to tell us how to reproduce it Provide as much information as you can. You may think that the problem lies with your query, when actually it depends on how your data is indexed. The easier it is for us to recreate your problem, the faster it is likely to be fixed. -1. Fork the repository. -2. Modify the source; please focus on the specific change you are contributing. If you also reformat all the code, it will be hard for us to focus on your change. -3. Ensure local tests pass. -4. Commit to your fork using clear commit messages. -5. Send us a pull request, answering any default questions in the pull request interface. -6. Pay attention to any automated CI failures reported in the pull request, and stay involved in the conversation. +### Feature Requests -GitHub provides additional document on [forking a repository](https://help.github.com/articles/fork-a-repo/) and -[creating a pull request](https://help.github.com/articles/creating-a-pull-request/). +If you've thought of a way that OpenSearch could be better, we want to hear about it. We track feature requests using GitHub, so please feel free to open an issue which describes the feature you would like to see, why you need it, and how it should work. -## Finding contributions to work on -Looking at the existing issues is a great way to find something to contribute on. As our projects, by default, use the default GitHub issue labels (enhancement/bug/duplicate/help wanted/invalid/question/wontfix), looking at any 'help wanted' issues is a great place to start. +### Contributing Code +As with other types of contributions, the first step is to [open an issue on GitHub](https://github.com/opensearch-project/opensearch-api-specification/issues/new/choose). Opening an issue before you make changes makes sure that someone else isn't already working on that particular problem. It also lets us all work together to find the right approach before you spend a bunch of time on a PR. So again, when in doubt, open an issue. -## Code of Conduct -This project has adopted the [Amazon Open Source Code of Conduct](https://aws.github.io/code-of-conduct). -For more information see the [Code of Conduct FAQ](https://aws.github.io/code-of-conduct-faq) or contact -opensource-codeofconduct@amazon.com with any additional questions or comments. +## Developer Certificate of Origin +OpenSearch is an open source product released under the Apache 2.0 license (see either [the Apache site](https://www.apache.org/licenses/LICENSE-2.0) or the [LICENSE.txt file](LICENSE.txt)). The Apache 2.0 license allows you to freely use, modify, distribute, and sell your own products that include Apache 2.0 licensed software. -## Security issue notifications -If you discover a potential security issue in this project we ask that you notify AWS/Amazon Security via our [vulnerability reporting page](http://aws.amazon.com/security/vulnerability-reporting/). Please do **not** create a public github issue. +We respect intellectual property rights of others and we want to make sure all incoming contributions are correctly attributed and licensed. A Developer Certificate of Origin (DCO) is a lightweight mechanism to do that. +The DCO is a declaration attached to every contribution made by every developer. In the commit message of the contribution, the developer simply adds a `Signed-off-by` statement and thereby agrees to the DCO, which you can find below or at [DeveloperCertificate.org](http://developercertificate.org/). -## Licensing +``` +Developer's Certificate of Origin 1.1 +By making a contribution to this project, I certify that: +(a) The contribution was created in whole or in part by me and I + have the right to submit it under the open source license + indicated in the file; or +(b) The contribution is based upon previous work that, to the + best of my knowledge, is covered under an appropriate open + source license and I have the right under that license to + submit that work with modifications, whether created in whole + or in part by me, under the same open source license (unless + I am permitted to submit under a different license), as + Indicated in the file; or +(c) The contribution was provided directly to me by some other + person who certified (a), (b) or (c) and I have not modified + it. +(d) I understand and agree that this project and the contribution + are public and that a record of the contribution (including + all personal information I submit with it, including my + sign-off) is maintained indefinitely and may be redistributed + consistent with this project or the open source license(s) + involved. + ``` -See the [LICENSE](LICENSE) file for our project's licensing. We will ask you to confirm the licensing of your contribution. +We require that every contribution to OpenSearch is signed with a Developer Certificate of Origin. Additionally, please use your real name. We do not accept anonymous contributors nor those utilizing pseudonyms. + +Each commit must include a DCO which looks like this + +``` +Signed-off-by: Jane Smith +``` + +You may type this line on your own when writing your commit messages. However, if your user.name and user.email are set in your git configs, you can use `-s` or `– – signoff` to add the `Signed-off-by` line to the end of the commit message. + +## Review Process + +We deeply appreciate everyone who takes the time to make a contribution. We will review all contributions as quickly as possible. As a reminder, [opening an issue](https://github.com/opensearch-project/opensearch-api-specification/issues/new/choose) discussing your change before you make it is the best way to smooth the PR process. This will prevent a rejection because someone else is already working on the problem, or because the solution is incompatible with the architectural direction. + +During the PR process, expect that there will be some back-and-forth. Please try to respond to comments in a timely fashion, and if you don't wish to continue with the PR, let us know. If a PR takes too many iterations for its complexity or size, we may reject it. Additionally, if you stop responding we may close the PR as abandoned. In either case, if you feel this was done in error, please add a comment on the PR. + +If we accept the PR, a [maintainer](MAINTAINERS.md) will merge your change and usually take care of backporting it to appropriate branches ourselves. + +If we reject the PR, we will close the pull request with a comment explaining why. This decision isn't always final: if you feel we have misunderstood your intended change or otherwise think that we should reconsider then please continue the conversation with a comment on the PR and we'll do our best to address any further points you raise. diff --git a/DEVELOPER_GUIDE.md b/DEVELOPER_GUIDE.md index a227c385d..2fcad8578 100644 --- a/DEVELOPER_GUIDE.md +++ b/DEVELOPER_GUIDE.md @@ -9,11 +9,11 @@ - [File Structure](#file-structure) - [Defining the API model](#defining-the-api-model) - [Adding a test-case for API definition](#adding-a-test-case-for-api-definition) - - [File Structure](#file-structure-for-test-folder) + - [File Structure for Test-folder](#file-structure-for-test-folder) - [Defining test-case for API model](#defining-test-case-for-api-model) - [Local testing](#local-testing) - - [Pre-requisites](#pre-requisite) - - [Testing model API](#testing-model-api) + - [Pre-requisite](#pre-requisite) + - [Testing model API](#testing-model-api) # Developer Guide Welcome to the ```opensearch-api-specification``` developer guide! Glad you want to contribute. Here are the things you need to know while getting started! diff --git a/LICENSE b/LICENSE.txt similarity index 100% rename from LICENSE rename to LICENSE.txt diff --git a/MAINTAINERS.md b/MAINTAINERS.md new file mode 100644 index 000000000..303d16b0d --- /dev/null +++ b/MAINTAINERS.md @@ -0,0 +1,19 @@ +- [Current Maintainers](#current-maintainers) +- [Maintainer Responsibilities](#maintainer-responsibilities) + +## Current Maintainers + +| Maintainer | GitHub ID | Affiliation | +| ------------------------ | ------------------------------------------------------ | ----------- | +| Abhi Kalra | [abhivka7](https://github.com/abhivka7) | Amazon | +| Daniel Doubrovkine | [dblock](https://github.com/dblock) | Amazon | +| Harsha Vamsi Kalluri | [harshavamsi](https://github.com/harshavamsi) | Amazon | +| Pranav Garg | [pgtgrly](https://github.com/pgtgrly) | Amazon | +| Sachet Alva | [sachetalva](https://github.com/sachetalva) | Amazon | +| Theo Truong | [nhtruong](https://github.com/nhtruong) | Amazon | +| Thomas Farr | [Xtansia](https://github.com/Xtansia) | Amazon | +| Vacha Shah | [VachaShah](https://github.com/VachaShah) | Amazon | + +## Maintainer Responsibilities + +[This document](https://github.com/opensearch-project/.github/blob/main/MAINTAINERS.md) explains what maintainers do in this repo, and how they should be doing it. If you're interested in contributing, see [CONTRIBUTING](CONTRIBUTING.md). \ No newline at end of file diff --git a/NOTICE b/NOTICE deleted file mode 100644 index 616fc5889..000000000 --- a/NOTICE +++ /dev/null @@ -1 +0,0 @@ -Copyright Amazon.com, Inc. or its affiliates. All Rights Reserved. diff --git a/NOTICE.txt b/NOTICE.txt new file mode 100644 index 000000000..46ffe3ba2 --- /dev/null +++ b/NOTICE.txt @@ -0,0 +1,2 @@ +OpenSearch (https://opensearch.org/) +Copyright OpenSearch Contributors \ No newline at end of file diff --git a/README.md b/README.md index 3cb52bdcb..23fcfe432 100644 --- a/README.md +++ b/README.md @@ -2,6 +2,7 @@ ## OpenSearch API Specification +- [OpenSearch API Specification](#opensearch-api-specification) - [Welcome!](#welcome) - [Project Resources](#project-resources) - [Code of Conduct](#code-of-conduct) diff --git a/SECURITY.md b/SECURITY.md new file mode 100644 index 000000000..b86292104 --- /dev/null +++ b/SECURITY.md @@ -0,0 +1,3 @@ +## Reporting a Vulnerability + +If you discover a potential security issue in this project we ask that you notify AWS/Amazon Security via our [vulnerability reporting page](http://aws.amazon.com/security/vulnerability-reporting/) or directly via email to aws-security@amazon.com. Please do **not** create a public GitHub issue.